The 3.22 release is coming and Jenkins is not happy at all (http://jenkins.koha-community.org/). All tests should pass before the release!
This is obviously caused because our test suite is dependent of the data of a given DB (see bug 10273).
Created attachment 43594 [details] [review] Bug 15028: tests - force the numbering pattern to 'No. {X}' On some jenkins DB, this pattern is "No.{X}" instead of "No. {X}" and the test fails ("Serial notification text constructed successfully").
Created attachment 43595 [details] [review] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs On some jenkins DBs, this pattern is "No.{X}" instead of "No. {X}" and the test fails ("Serial notification text constructed successfully"). Tests should always create their own data. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 43596 [details] [review] [PASSED QA] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs On some jenkins DBs, this pattern is "No.{X}" instead of "No. {X}" and the test fails ("Serial notification text constructed successfully"). Tests should always create their own data. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Jonathan!