Everytime you enter barcode to add it to rotating collection, you get an error message: "Failed to add item with barcode xxx: NO_ID" Also, in empty collection you see table with items, but only with one empty row...
Josef, It looks good here: http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/rotating_collections/addItems.pl Could you please detail your issue?
Created attachment 44044 [details] rotating collection issue I'm adding a screenshot of the problem I'm facing
I understand now, when I created a new collection, I tried to add items and somehow was redirected on page addItems without colId parameter... so of course adding items failed...
Please provide a step by step plan to reproduce, I don't get it.
I can't reproduce it now as well... the problem was, I think, that collection ID was lost... but only one way I can reproduce it now is to manually go to address /cgi-bin/koha/rotating_collections/addItems.pl without any parameter... but it's not the way used by normal work....
Created attachment 44287 [details] Steps to reproduce error message (without plack) I can reproduce the issue in two steps (without plack): 1) Call /cgi-bin/koha/rotating_collections/addItems.pl without param Result: Screen to add items. Warning in intranet-error.log: Use of unitialized value in string eq at (...)adItems.pl line 42 Expected result: Should display an error message 2) Try to add an item Result: Displays error message: Failed to add item with barcode XXXX: NO_ID See screenshots attached. See screenshot.
Created attachment 44336 [details] [review] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem
Created attachment 44337 [details] [review] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 44348 [details] [review] [PASSED QA] Bug 15061: Can't add item to rotating collection This patch prevents adding items to invalid (empty) rotating collection id To test: 1) Go to /cgi-bin/koha/rotating_collections/addItems.pl 2) Try to add an item, you get error show in attached pictures 3) Apply the patch 4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl 5) Can't add any items I don't know if this is a real problem Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Bernardo!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.