Printing a summary from a member's detail page can result in a lot of warnings like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103
Created attachment 44062 [details] [review] Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear.
*** Bug 14483 has been marked as a duplicate of this bug. ***
(In reply to Marc Véron from comment #1) > - Use of uninitialized value in addition (+) > at /usr/share/kohaclone/members/summary-print.pl line 87 > > - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) > at /usr/share/kohaclone/members/summary-print.pl line 103 > ... > - Go to a detail page with a member who has a lot of fines ... And items checked out, potentially overdue. Triggering 47 and 61 is easy with the sample data after creating some fines on a user. Having difficulty triggering 87, which I feel will also trigger 103, if I have something checked out, but working on multiple bugs at once is hard. :)
(In reply to M. Tompsett from comment #3) > (In reply to Marc Véron from comment #1) > > - Use of uninitialized value in addition (+) > > at /usr/share/kohaclone/members/summary-print.pl line 87 > > > > - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) > > at /usr/share/kohaclone/members/summary-print.pl line 103 > > > ... > > - Go to a detail page with a member who has a lot of fines > ... > And items checked out, potentially overdue. > > Triggering 47 and 61 is easy with the sample data after creating some fines > on a user. Having difficulty triggering 87, which I feel will also trigger > 103, if I have something checked out, but working on multiple bugs at once > is hard. :) - 87 is due to items with no replacementprice (NULL in db) - 103 triggers with multiple checkouts with due dates
Created attachment 44322 [details] [review] Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Have been able to see those warnings in Apache log file, and notice their disappearance after applying this patch.
Created attachment 44350 [details] [review] [PASSED QA] Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Have been able to see those warnings in Apache log file, and notice their disappearance after applying this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Marc!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.