After the UX/UI patches got pushed, the only missing piece was making the breadcrumbs more consistent. The same applies to the page title.
Created attachment 44097 [details] [review] Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D
Created attachment 44098 [details] [review] Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI.
Created attachment 44099 [details] [review] Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too.
Created attachment 44120 [details] [review] Bug 14722: CSV is only available for biblio records Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment on attachment 44120 [details] [review] Bug 14722: CSV is only available for biblio records Sorry, i messed something whil trying to attach multiple patches.
Created attachment 44170 [details] [review] [SIGNED-OFF] Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 44171 [details] [review] [SIGNED-OFF] Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 44172 [details] [review] [SIGNED-OFF] Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All patches without errors. More consistent view. A few spaces and a little fix in followup
Created attachment 44173 [details] [review] Bug 15072: (followup) fix spaces and consistency This patch add a few spaces when required and adds layout_id on title and breadcrumbs (for patroncards) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 44188 [details] [review] Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44189 [details] [review] Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44190 [details] [review] Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All patches without errors. More consistent view. A few spaces and a little fix in followup Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44191 [details] [review] Bug 15072: (followup) fix spaces and consistency This patch add a few spaces when required and adds layout_id on title and breadcrumbs (for patroncards) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks for the followup, Bernardo!