Created attachment 44245 [details] missing item type images/text If there is no icon the item type description should show in the opac, but nothing is showing.
Problem here is in opac-search.pl $itemytpes = GetItemTypesCategorized; but this itemtypes don't have $itemtypes->{$thisitemtype}->{translated_description} which is the string printed I put Jonathan in CC, he knows better
Created attachment 44265 [details] [review] Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description
Created attachment 44267 [details] [review] Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 44271 [details] [review] [PASSED QA] Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Bernardo!
Created attachment 44338 [details] [review] Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present
Added followup to display search categories description
Created attachment 44366 [details] [review] Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off on second patch: Bug 15092: (followup) Descriptions not show for search categories.
Created attachment 44453 [details] [review] [PASSED QA] Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This is better, but still one small glitch - if you have no OPAC description set, it should fall back to the staff description like we usually do. But maybe this should go on a separate bug, so this can go in as is as fixing the bigger problem.
Followup pushed to master. Thanks Bernardo!