Bug 15099 - Fix file name: categorie.pl should be either category.pl or categories.pl
Summary: Fix file name: categorie.pl should be either category.pl or categories.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-01 20:17 UTC by Katrin Fischer
Modified: 2016-12-05 21:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15099: Move admin/categorie.pl to admin/categories.pl (14.06 KB, patch)
2015-12-02 08:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15099: Move admin/categorie.pl to admin/categories.pl (12.94 KB, patch)
2015-12-08 14:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15099: Move admin/categorie.pl to admin/categories.pl (13.02 KB, patch)
2015-12-08 14:33 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 15099: Move admin/categorie.pl to admin/categories.pl (13.09 KB, patch)
2015-12-13 22:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 15099: Move admin/categorie.pl to admin/categories.pl (13.11 KB, patch)
2015-12-30 15:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15099 [QA Followup] - Make bug pass koha-qa.pl (24.48 KB, patch)
2015-12-30 16:55 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-11-01 20:17:51 UTC
I keep stumbling over categorie.pl... it would be nice to fix the file name to be either category.pl or categories.pl :)
Comment 1 Jonathan Druart 2015-12-02 08:55:14 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2015-12-08 12:40:22 UTC
(In reply to Jonathan Druart from comment #1)

> Confirm that the admin/categorie.pl url still works (you need to apply
> the change to the apache config before).

I don't understand why an Apache rewrite rule is needed, and why it should be required that admin/categorie.pl continues to work.
Comment 3 Jonathan Druart 2015-12-08 13:24:01 UTC
(In reply to Frédéric Demians from comment #2)
> (In reply to Jonathan Druart from comment #1)
> 
> > Confirm that the admin/categorie.pl url still works (you need to apply
> > the change to the apache config before).
> 
> I don't understand why an Apache rewrite rule is needed, and why it should
> be required that admin/categorie.pl continues to work.

To avoid 404 using old links (from the browser history for instance).
But indeed, it could be removed if needed.
Comment 4 Frédéric Demians 2015-12-08 13:35:40 UTC
> To avoid 404 using old links (from the browser history for instance).
> But indeed, it could be removed if needed.

I would feel more comfortable signing this patch without the rewrite rule.
Just because Koha code has already its load of idiosyncrasies whose reasons
are lost in immemorial time...
Comment 5 Jonathan Druart 2015-12-08 14:22:03 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2015-12-08 14:22:23 UTC
Here it is!
Comment 7 Frédéric Demians 2015-12-08 14:33:59 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2015-12-13 22:25:03 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2015-12-30 15:39:49 UTC
Created attachment 46090 [details] [review]
Bug 15099: Move admin/categorie.pl to admin/categories.pl

This patch fixes the filename categorie.pl correcting it by categories.pl
The plurial is usually used for script names in the admin module.

Test plan:
Navigate to the patron categories page.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  No reference to categorie.pl anywhere in the code

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Kyle M Hall 2015-12-30 16:55:49 UTC
Created attachment 46094 [details] [review]
Bug 15099 [QA Followup] - Make bug pass koha-qa.pl

Cleaned up additional tab characters and such well. This is a very
good time to take care of these.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 11 Kyle M Hall 2015-12-30 16:57:06 UTC
Pushed to master, thanks Jonathan!
Comment 12 Julian Maurice 2016-03-14 10:32:30 UTC
I won't push these patches to 3.22.x, so status changed to RESOLVED