I keep stumbling over categorie.pl... it would be nice to fix the file name to be either category.pl or categories.pl :)
Created attachment 45308 [details] [review] Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before).
(In reply to Jonathan Druart from comment #1) > Confirm that the admin/categorie.pl url still works (you need to apply > the change to the apache config before). I don't understand why an Apache rewrite rule is needed, and why it should be required that admin/categorie.pl continues to work.
(In reply to Frédéric Demians from comment #2) > (In reply to Jonathan Druart from comment #1) > > > Confirm that the admin/categorie.pl url still works (you need to apply > > the change to the apache config before). > > I don't understand why an Apache rewrite rule is needed, and why it should > be required that admin/categorie.pl continues to work. To avoid 404 using old links (from the browser history for instance). But indeed, it could be removed if needed.
> To avoid 404 using old links (from the browser history for instance). > But indeed, it could be removed if needed. I would feel more comfortable signing this patch without the rewrite rule. Just because Koha code has already its load of idiosyncrasies whose reasons are lost in immemorial time...
Created attachment 45494 [details] [review] Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Confirm that the admin/categorie.pl url still works (you need to apply the change to the apache config before).
Here it is!
Created attachment 45495 [details] [review] Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No reference to categorie.pl anywhere in the code
Created attachment 45627 [details] [review] [PASSED QA] Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No reference to categorie.pl anywhere in the code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46090 [details] [review] Bug 15099: Move admin/categorie.pl to admin/categories.pl This patch fixes the filename categorie.pl correcting it by categories.pl The plurial is usually used for script names in the admin module. Test plan: Navigate to the patron categories page. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> No reference to categorie.pl anywhere in the code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46094 [details] [review] Bug 15099 [QA Followup] - Make bug pass koha-qa.pl Cleaned up additional tab characters and such well. This is a very good time to take care of these. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master, thanks Jonathan!
I won't push these patches to 3.22.x, so status changed to RESOLVED