Bug 15101 - Don't display system preference AllowPkiAuth under heading CAS Authentication
Summary: Don't display system preference AllowPkiAuth under heading CAS Authentication
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-01 20:26 UTC by Katrin Fischer
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading (1.61 KB, patch)
2015-11-22 01:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading (1.71 KB, patch)
2015-11-24 13:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth (1.43 KB, patch)
2015-11-25 16:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading (1.73 KB, patch)
2015-11-25 16:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth (1.43 KB, patch)
2015-11-25 16:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading (1.80 KB, patch)
2015-12-30 02:18 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth (1.50 KB, patch)
2015-12-30 02:18 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2015-11-01 20:26:46 UTC
We should not display system preference AllowPkiAuth below heading CAS Authentication, because it's a different thing.
Comment 1 Katrin Fischer 2015-11-22 01:45:31 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2015-11-24 13:50:36 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-11-25 16:47:21 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-11-25 16:47:42 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2015-11-25 16:47:47 UTC Comment hidden (obsolete)
Comment 6 Brendan Gallagher 2015-12-30 02:18:40 UTC
Created attachment 46052 [details] [review]
Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading

The system preference AllowPkiAuth display under the heading
CAS authentication, but is actually a separate authentication
option. Patch creates a separate heading for it.

To test:
- Go to Administration > System preferences > Tab Administration
- Verify that AllowPkiAuth is now displayed separately

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 7 Brendan Gallagher 2015-12-30 02:18:50 UTC
Created attachment 46053 [details] [review]
Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 8 Brendan Gallagher 2015-12-30 02:19:09 UTC
Pushed to master - Thanks
Comment 9 Julian Maurice 2015-12-30 16:30:08 UTC
Patches pushed to 3.22.x, will be in 3.22.2
Comment 10 Frédéric Demians 2015-12-31 18:27:16 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.