On intranet catalog detail in tab Image, the way in which the the link is displayed for "Please <a>upload</a> one" for some languages (Spanish my case) does not allow translate properly.
Sorry my mistake, the string really works well for translation purpose.
Still can use for a better context in translation The phrase "Please, %upload% one" isn't a good phrase for translation. It is much better something like "Select the image file to upload"
Created attachment 44607 [details] [review] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES
Created attachment 44608 [details] [review] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Select a bib record without a local cover image -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES
Created attachment 44609 [details] [review] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians <f.demians@tamil.fr> A native English speaker could confirm that the wording is ok: Please select the image file to upload
Created attachment 44784 [details] [review] [PASSED QA] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians <f.demians@tamil.fr> A native English speaker could confirm that the wording is ok: Please select the image file to upload Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Hector!
This patch has been pushed to 3.20.x, will be in 3.20.6.
Pushed to 3.18.13, and released.