Displays the items.enumchron-column in returns.pl when checking in Items.
Created attachment 44736 [details] [review] Bug 15172 - Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Pending web testing
Failed QA because of missing tests.
Tests for template changes in .pl files are not required?
Created attachment 44811 [details] [review] [SIGNED-OFF]Bug 15172 - Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> items.enumchron-column display successful in returns.pl (Home>Circulation> Check in)
The br and span tags should only be displayed if the value enumchron exists.
Created attachment 45334 [details] [review] Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear
Auto-merging circ/returns.pl CONFLICT (content): Merge conflict in circ/returns.pl Failed to merge in the changes. Patch failed at 0001 Bug 15172 - Serial enumchron/sequence not visible when returning/checking in Items
Created attachment 49642 [details] [review] Bug 15172: Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> items.enumchron-column display successful in returns.pl (Home>Circulation> Check in) NOTE: Patch rebased on master
Created attachment 49643 [details] [review] Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear
Is this duplicate in functionality to 14668?
(In reply to Liz Rea from comment #10) > Is this duplicate in functionality to 14668? This patch still applies. QA should decide if close this bug as duplicated of bug 14668 or keep it open. Regards
Patch tested with a sandbox, by Alain et Aurélie <aurelie.berut@enssib.fr>
Created attachment 52944 [details] [review] Bug 15172: Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> items.enumchron-column display successful in returns.pl (Home>Circulation> Check in) NOTE: Patch rebased on master Signed-off-by: Alain et Aur
Created attachment 52945 [details] [review] Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear Signed-off-by: Alain et Aur
Tested by Aurélie Bérut and Alain Griot during the french symposium testing party : It works as described : - when checkin a serial item, information about the volume,enumchron are displayed in the title column under the title. - when checkin a book, br and span are not present in the code source page for this element
Created attachment 53074 [details] [review] Bug 15172: Serial enumchron/sequence not visible when returning/checking in Items Displays the items.enumchron-column in returns.pl when checking in Items. Rewording commit To test: -Checkout a barcode for serial with items generated in Serials > New subscription or item in DB with items.enumchron-column -Checkin the same barcode, the table Checked-in items will appear without information about "Publications details (Vol. 400, No. 32)" -Apply patch -Checkout and checkin another item of the same serial title -Notice about the Vol. 400, No. 32 below the serial title. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> items.enumchron-column display successful in returns.pl (Home>Circulation> Check in) NOTE: Patch rebased on master Signed-off-by: Alain et Aurélie <aurelie.berut@enssib.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 53075 [details] [review] Bug 15172: (follow-up)Serial enumchron/sequence not visible when returning/checking in Items Display br and span tag only if the value enumchron exists. To test -Apply patches -Follow the previous test plan -Checkin whichever material (e.g., book) without sequence or enumchrom -Open up source code for checkin page, search under title and verify that b and span tags do not appear Signed-off-by: Alain et Aurélie <aurelie.berut@enssib.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 16.11, thanks Olli, Hector!
Pushed in 16.05. Will be in 16.05.02.