circ/stats.pl and koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt seem not to be used. To verify: git grep '/stats.pl' koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt:<!-- <li> <a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">Daily koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt: <li><a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">yesterday</a></l koha-tmpl/intranet-tmpl/prog/en/modules/circ/stats.tt: <li><a href="/cgi-bin/koha/circ/stats.pl?time=today">today</a></li> The reference to stats.pl in circulation-home.tt is commented out.
Created attachment 45069 [details] [review] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file.
Created attachment 45123 [details] [review] [SIGNED-OFF] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 45148 [details] [review] Bug 15230: Remove unused file circ/stats.pl and stats.tt from system This patch removes stats.pl and stats.tt from system. To test: - Verify that both files are not used and that the only reference in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt is commented out. - Apply patch - Verify that the files are deleted and the reference is removed. - git grep 'stats.pl', verify that there are no more references to this file. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> See the following commit for more info on this script: commit 60105bd692a07639f275543365acfca4f464c1a2 Date: Tue Jul 8 20:02:34 2008 -0500 fix for 2008: Daily reconciliation report broken
Pushed to master! Thanks Marc!
Patch pushed to 3.22.x, will be in 3.22.1