Bug 15232 - Advanced Cataloging Editor: Fix translation issues
Summary: Advanced Cataloging Editor: Fix translation issues
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-23 06:42 UTC by Marc Véron
Modified: 2017-06-14 22:07 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15232: Advanced Cataloging Editor: Fix translation issues (2.14 KB, patch)
2015-11-23 07:05 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15232: (follow-up) Advanced Cataloging Editor: Fix translation issues (1.77 KB, patch)
2015-11-23 16:38 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15232: Advanced Cataloging Editor: Fix translation issues (2.34 KB, patch)
2015-11-25 06:44 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 15232: Advanced Cataloging Editor: Fix translation issues (2.41 KB, patch)
2015-11-25 15:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15232: Advanced Cataloging Editor: Fix translation issues (2.48 KB, patch)
2015-12-29 23:02 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-11-23 06:42:01 UTC
The advanced cataloging editor contains strings that do not conform to

http://wiki.koha-community.org/wiki/Coding_Guidelines#JS3:_Avoid_strings_which_mix_text_and_markup

"JS3: Avoid strings which mix text and markup
Text mustn't contain HTML tags."

That makes translations errorprone.

Additionally, the fav icon is not displayed.
Comment 1 Marc Véron 2015-11-23 06:57:03 UTC
Fav icon issue seems to be browser dependent (FF only); removed from this bug.
Comment 2 Marc Véron 2015-11-23 07:05:36 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2015-11-23 16:33:34 UTC
Sorry, Marc

But not a good solution

If you trick a macro for example 500=‡aEdited with Rancor and you change for 500‡aEdited with Rancor, the message displayed is:

h3Failed to run macro:
Comment 4 Héctor Eduardo Castro Avalos 2015-11-23 16:38:15 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2015-11-23 19:24:26 UTC
Thanks Héctor for fixiing my error, I commited a little bit to fast... 
:-)
Comment 6 Frédéric Demians 2015-11-25 06:44:33 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2015-11-25 15:09:48 UTC Comment hidden (obsolete)
Comment 8 Brendan Gallagher 2015-12-29 23:02:57 UTC
Created attachment 46040 [details] [review]
Bug 15232: Advanced Cataloging Editor: Fix translation issues

This patch makes
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with
Coding guidlines to avoid translation issues: "JS3: Avoid strings which
mix text and markup Text mustn't contain HTML tags."

To test:
- Apply patch
- Verify that code changes are correct (html markup moved out of
  function _(...) )
- Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify
  that it works as before

With type fix from: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 9 Brendan Gallagher 2015-12-29 23:03:24 UTC
Pushed to master - thanks
Comment 10 Julian Maurice 2015-12-30 16:19:18 UTC
Patch pushed in 3.22.x, will be in 3.22.2