The advanced cataloging editor contains strings that do not conform to http://wiki.koha-community.org/wiki/Coding_Guidelines#JS3:_Avoid_strings_which_mix_text_and_markup "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." That makes translations errorprone. Additionally, the fav icon is not displayed.
Fav icon issue seems to be browser dependent (FF only); removed from this bug.
Created attachment 45094 [details] [review] Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before
Sorry, Marc But not a good solution If you trick a macro for example 500=‡aEdited with Rancor and you change for 500‡aEdited with Rancor, the message displayed is: h3Failed to run macro:
Created attachment 45110 [details] [review] Bug 15232: (follow-up) Advanced Cataloging Editor: Fix translation issues Change JS 'h3' for <h3>
Thanks Héctor for fixiing my error, I commited a little bit to fast... :-)
Created attachment 45129 [details] [review] Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Created attachment 45143 [details] [review] Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46040 [details] [review] Bug 15232: Advanced Cataloging Editor: Fix translation issues This patch makes koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with Coding guidlines to avoid translation issues: "JS3: Avoid strings which mix text and markup Text mustn't contain HTML tags." To test: - Apply patch - Verify that code changes are correct (html markup moved out of function _(...) ) - Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify that it works as before With type fix from: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to master - thanks
Patch pushed in 3.22.x, will be in 3.22.2