Bug 15233 - Cataloging subfield editors: Clean up html and streamline text for better translatability
Summary: Cataloging subfield editors: Clean up html and streamline text for better tra...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-23 07:37 UTC by Marc Véron
Modified: 2017-06-14 22:08 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability (3.27 KB, patch)
2015-11-23 07:41 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability (3.37 KB, patch)
2015-11-23 16:12 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15233: (followup) Remove 2 sentences. (2.44 KB, patch)
2015-12-04 15:05 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15233: (followup) Remove 2 sentences. (2.51 KB, patch)
2015-12-04 15:17 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability (3.43 KB, patch)
2015-12-07 10:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15233: (followup) Remove 2 sentences. (2.56 KB, patch)
2015-12-07 10:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability (3.50 KB, patch)
2015-12-29 23:27 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 15233: (followup) Remove 2 sentences. (2.63 KB, patch)
2015-12-29 23:28 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-11-23 07:37:09 UTC
Remove bold markup from explanatory text in auth_subfields_structure.tt and make it the same as in marc_subfields_structure.tt for better translatibility.
Comment 1 Marc Véron 2015-11-23 07:41:53 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-11-23 16:12:05 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-11-25 16:30:31 UTC
-<p>The column Koha field shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, or a Koha interface. This link ensures that both DB are synchronized, thus you can change from a MARC to a Koha interface easily.</p>

+<p>The column 'Koha field' shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.</p>

Why did you remove the end of the sentence?
Comment 4 Marc Véron 2015-11-25 16:55:16 UTC
(In reply to Jonathan Druart from comment #3)
> -<p>The column Koha field shows that the subfield is linked with a Koha
> field. Koha can manage a MARC interface, or a Koha interface. This link
> ensures that both DB are synchronized, thus you can change from a MARC to a
> Koha interface easily.</p>
> 
> +<p>The column 'Koha field' shows that the subfield is linked with a Koha
> field. Koha can manage a MARC interface, and a Koha interface. This link
> ensures that both DB are synchronized.</p>
> 
> Why did you remove the end of the sentence?

Oh, sorry, that was a mistake.
Comment 5 Marc Véron 2015-12-02 10:48:35 UTC
(In reply to Jonathan Druart from comment #3)
> -<p>The column Koha field shows that the subfield is linked with a Koha
> field. Koha can manage a MARC interface, or a Koha interface. This link
> ensures that both DB are synchronized, thus you can change from a MARC to a
> Koha interface easily.</p>
> 
> +<p>The column 'Koha field' shows that the subfield is linked with a Koha
> field. Koha can manage a MARC interface, and a Koha interface. This link
> ensures that both DB are synchronized.</p>
> 
> Why did you remove the end of the sentence?

Ah, now I see what I did. It was not a mistake.

Both texts have the same meaning, but a different wording. That's why I re-used the text from auth_subfields_structure.tt in marc_subfields_structure.tt

I propose to switch back to signed-off.
Comment 6 Jonathan Druart 2015-12-02 10:56:26 UTC
Nicole, do you agree to remove "thus you can change from a MARC to a Koha interface easily."?
Comment 7 Nicole C. Engard 2015-12-04 14:07:27 UTC
Yes, I agree, but I have another question. What does 'Koha can manage a MARC interface, and a Koha interface.' mean? What is a koha interface?

Nicole
Comment 8 Marc Véron 2015-12-04 14:12:14 UTC
I took the text as it was.

I propose to remove the sentence "Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized."(In reply to Nicole C. Engard from comment #7)
> Yes, I agree, but I have another question. What does 'Koha can manage a MARC
> interface, and a Koha interface.' mean? What is a koha interface?
> 
> Nicole

I took the text as it was.

What about removing the sentence the whole sentence? 
("Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.")
Comment 9 Nicole C. Engard 2015-12-04 14:39:16 UTC
Makes perfect sense to me. Delete away! :)
Comment 10 Marc Véron 2015-12-04 15:05:55 UTC Comment hidden (obsolete)
Comment 11 Marc Véron 2015-12-04 15:07:54 UTC
I hope it's OK to switch back to "Signed-off".
Comment 12 Héctor Eduardo Castro Avalos 2015-12-04 15:17:05 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2015-12-07 10:03:08 UTC Comment hidden (obsolete)
Comment 14 Jonathan Druart 2015-12-07 10:03:12 UTC Comment hidden (obsolete)
Comment 15 Brendan Gallagher 2015-12-29 23:27:51 UTC
Created attachment 46041 [details] [review]
Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability

This patch removes bold markup from explanatory text in auth_subfields_structure.tt
and makes it the same as in marc_subfields_structure.tt for better translatibility.

To test:
- Apply patch
- Verify that string changes make sense and that the explanatory text is the same in both files.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 16 Brendan Gallagher 2015-12-29 23:28:01 UTC
Created attachment 46042 [details] [review]
Bug 15233: (followup) Remove 2 sentences.

This patch removes 2 sentences (see comment #8)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 17 Brendan Gallagher 2015-12-29 23:28:25 UTC
Pushed to master - thanks!
Comment 18 Julian Maurice 2015-12-30 16:22:38 UTC
Patches pushed to 3.22.x, will be in 3.22.2
Comment 19 Frédéric Demians 2015-12-31 18:25:43 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.