Remove bold markup from explanatory text in auth_subfields_structure.tt and make it the same as in marc_subfields_structure.tt for better translatibility.
Created attachment 45095 [details] [review] Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files.
Created attachment 45109 [details] [review] [SIGNED-OFF]Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purposes
-<p>The column Koha field shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, or a Koha interface. This link ensures that both DB are synchronized, thus you can change from a MARC to a Koha interface easily.</p> +<p>The column 'Koha field' shows that the subfield is linked with a Koha field. Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.</p> Why did you remove the end of the sentence?
(In reply to Jonathan Druart from comment #3) > -<p>The column Koha field shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, or a Koha interface. This link > ensures that both DB are synchronized, thus you can change from a MARC to a > Koha interface easily.</p> > > +<p>The column 'Koha field' shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, and a Koha interface. This link > ensures that both DB are synchronized.</p> > > Why did you remove the end of the sentence? Oh, sorry, that was a mistake.
(In reply to Jonathan Druart from comment #3) > -<p>The column Koha field shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, or a Koha interface. This link > ensures that both DB are synchronized, thus you can change from a MARC to a > Koha interface easily.</p> > > +<p>The column 'Koha field' shows that the subfield is linked with a Koha > field. Koha can manage a MARC interface, and a Koha interface. This link > ensures that both DB are synchronized.</p> > > Why did you remove the end of the sentence? Ah, now I see what I did. It was not a mistake. Both texts have the same meaning, but a different wording. That's why I re-used the text from auth_subfields_structure.tt in marc_subfields_structure.tt I propose to switch back to signed-off.
Nicole, do you agree to remove "thus you can change from a MARC to a Koha interface easily."?
Yes, I agree, but I have another question. What does 'Koha can manage a MARC interface, and a Koha interface.' mean? What is a koha interface? Nicole
I took the text as it was. I propose to remove the sentence "Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized."(In reply to Nicole C. Engard from comment #7) > Yes, I agree, but I have another question. What does 'Koha can manage a MARC > interface, and a Koha interface.' mean? What is a koha interface? > > Nicole I took the text as it was. What about removing the sentence the whole sentence? ("Koha can manage a MARC interface, and a Koha interface. This link ensures that both DB are synchronized.")
Makes perfect sense to me. Delete away! :)
Created attachment 45416 [details] [review] Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8)
I hope it's OK to switch back to "Signed-off".
Created attachment 45417 [details] [review] [SIGNED-OFF]Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 45442 [details] [review] Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purposes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45443 [details] [review] Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46041 [details] [review] Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability This patch removes bold markup from explanatory text in auth_subfields_structure.tt and makes it the same as in marc_subfields_structure.tt for better translatibility. To test: - Apply patch - Verify that string changes make sense and that the explanatory text is the same in both files. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purposes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Created attachment 46042 [details] [review] Bug 15233: (followup) Remove 2 sentences. This patch removes 2 sentences (see comment #8) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to master - thanks!
Patches pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.