15237 – Quote of the day: Better translatibility for editor and help

Bug 15237 - Quote of the day: Better translatibility for editor and help

Summary: Quote of the day: Better translatibility for editor and help

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	I18N/L10N (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low trivial
Assignee:	Marc Véron
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:

Reported:	2015-11-23 08:24 UTC by Marc Véron
Modified:	2017-06-14 22:10 UTC (History)
CC List:	4 users (show)

See Also:	14459
Change sponsored?:	---
Patch complexity:	String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15237 - Quote of the day: Better translatibility for editor and help (3.10 KB, patch) 2015-11-23 08:42 UTC, Marc Véron	Details \| Diff \| Splinter Review
Bug 15237 - Quote of the day: Better translatibility for editor and help (3.10 KB, patch) 2015-11-23 08:59 UTC, Marc Véron	Details \| Diff \| Splinter Review
Bug 15237 - Quote of the day: Better translatibility for editor and help (3.10 KB, patch) 2015-11-23 09:00 UTC, Marc Véron	Details \| Diff \| Splinter Review
[SIGNED-OFF]Bug 15237: Quote of the day: Better translatibility for editor and help (3.20 KB, patch) 2015-11-23 15:54 UTC, Héctor Eduardo Castro Avalos	Details \| Diff \| Splinter Review
Bug 15237: Quote of the day: Better translatibility for editor and help (3.33 KB, patch) 2015-11-25 16:23 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 15237: Quote of the day: Better translatibility for editor and help (3.39 KB, patch) 2015-12-30 00:29 UTC, Brendan Gallagher	Details \| Diff \| Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Véron 2015-11-23 08:24:15 UTC

Remove html markup out of explanatory text in Quote of the day editor and help for better translatibility (Home > Tools > Quote Editor).

Comment 1 Marc Véron 2015-11-23 08:42:06 UTC Comment hidden (obsolete)

Created attachment 45100 [details] [review]
Bug 15237 - Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Comment 2 Marc Véron 2015-11-23 08:59:36 UTC Comment hidden (obsolete)

Created attachment 45102 [details] [review]
Bug 15237 - Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Comment 3 Marc Véron 2015-11-23 09:00:45 UTC Comment hidden (obsolete)

Created attachment 45103 [details] [review]
Bug 15237 - Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Comment 4 Héctor Eduardo Castro Avalos 2015-11-23 15:54:59 UTC Comment hidden (obsolete)

Created attachment 45107 [details] [review]
[SIGNED-OFF]Bug 15237: Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Comment 5 Jonathan Druart 2015-11-25 16:23:11 UTC Comment hidden (obsolete)

Created attachment 45160 [details] [review]
Bug 15237: Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Make consistent space after "Note:" (inside the br tag)

Comment 6 Brendan Gallagher 2015-12-30 00:29:08 UTC

Created attachment 46044 [details] [review]
Bug 15237: Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Make consistent space after "Note:" (inside the br tag)

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>

Comment 7 Brendan Gallagher 2015-12-30 00:29:23 UTC

Pushed to master - Thanks

Comment 8 Julian Maurice 2015-12-30 16:24:44 UTC

Patch pushed to 3.22.x, will be in 3.22.2

Comment 9 Frédéric Demians 2015-12-31 18:26:16 UTC

This patch has been pushed to 3.20.x, will be in 3.20.8.