On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package
Created attachment 45254 [details] [review] Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error.
Created attachment 45255 [details] [review] Bug 15270: Add regression tests for Koha::Objects->find
Created attachment 45256 [details] [review] [FOR 3.20.X ONLY] Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error.
The 2 patches are for 3.20.x but it would be good to get the first one (the tests) on master too.
Created attachment 45262 [details] [review] Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. Signed-off-by: Magnus Enger <magnus@libriotech.no> Set AnonymousPatron pref to a nonexistent borrowernumber. Before the patch, about.pl shows a nasty error. After applying the patch the error is gone. Tests in t/db_dependent/Objects.t pass.
Created attachment 45263 [details] [review] Bug 15270: Add regression tests for Koha::Objects->find Signed-off-by: Magnus Enger <magnus@libriotech.no>
(In reply to Jonathan Druart from comment #4) > The 2 patches are for 3.20.x but it would be good to get the first one (the > tests) on master too. I can see the bug and the solution. Can I QA myself those patches, and then pushed them on 3.20, am I supposed to wait someone else from the QA team to validate this before?
(In reply to Frédéric Demians from comment #7) > (In reply to Jonathan Druart from comment #4) > > The 2 patches are for 3.20.x but it would be good to get the first one (the > > tests) on master too. > > I can see the bug and the solution. Can I QA myself those patches, and then > pushed them on 3.20, am I supposed to wait someone else from the QA team to > validate this before? I don't know, I think the RMaints have the responsibility of keeping their branch stable :) Since you are releasing at the end of the month, maybe it is worth to wait for another pair of eyes?
Please wait for the QA team. If something is urgently needed, feel free to nudge me or one of the others about it.
(In reply to Katrin Fischer from comment #9) > Please wait for the QA team. If something is urgently needed, feel free to > nudge me or one of the others about it. OK
Created attachment 45438 [details] [review] [PASSED QA] Bug 15270: Make Koha::Objects->find return undef instead of crashing On 3.20.05, if AnonymousPatron is set to a nonexistent borrowernumber, the about.pl crashes with DBIC result type isn't of the type Borrower at /home/koha/src/Koha/Objects.pm line 87. This was fixed on master by commit 6882949b1b3bd1284e3d2877244a64edee3883ca Date: Wed Apr 8 06:38:34 2015 -0400 Bug 13967 - System preferences need a package Test plan: Set the AnonymousPatron pref to a nonexistent borrowernumber Go on about.pl Without this patch, you get the error. Signed-off-by: Magnus Enger <magnus@libriotech.no> Set AnonymousPatron pref to a nonexistent borrowernumber. Before the patch, about.pl shows a nasty error. After applying the patch the error is gone. Tests in t/db_dependent/Objects.t pass. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 45439 [details] [review] [PASSED QA] Bug 15270: Add regression tests for Koha::Objects->find Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This patch has been pushed to 3.20.x, will be in 3.20.7.