In /circ/circulation.pl, the sentence "Checkouts are BLOCKED because fine balance is OVER THE LIMIT." translates in German to: "Ausleihen sind GESPERRT weil Gebührenkonto ist ÜBER BEGRENZUNG." That is simply wrong, and it is almost impossible to translate correctly because the strings are splitted by html tags.
I suppose we can either take the tags out completely or put the entire string within the tags. I can write a patch for both options
Created attachment 46672 [details] [review] Bug 15274: Removing <span> tags from circulation.tt which split the sentence I have only removed the <span class="circ-hlt"> </span> tags from strings where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the "ITEMS OVERDUE" in the error message is no longer styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the "BLOCKED" and "OVER THE LIMIT" is no longer styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult.
Created attachment 46673 [details] [review] [Alternative Patch] Bug 15274: Putting <span> tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable.
Created attachment 46680 [details] Screenshots to compare patches I made some screenshots. For this Bug I would prefer the alternative patch (whole sentence in tags). Most important thing at the moment is to get rid of the sentence splitting because of the really weird translations. The whole part with blocking messages can then be streamlined in a separate bug.
Created attachment 46681 [details] [review] Bug 15274: Putting <span> tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable. Signed off on this second patch, see screenshots in comment #4. (Forbidden tab char in line 779 removed) Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 46682 [details] [review] Bug 15274: Removing <span> tags from circulation.tt which split the sentence I have only removed the <span class="circ-hlt"> </span> tags from strings where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the "ITEMS OVERDUE" in the error message is no longer styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the "BLOCKED" and "OVER THE LIMIT" is no longer styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. Sign-off on first patch (offending tab char in line 779 removed) Signed-off-by: Marc Véron <veron@veron.ch>
Hi Aleisha, I signed off on both patches, I propose that you decide and obsolete one of them. :-)
(In reply to Marc Véron from comment #7) > Hi Aleisha, I signed off on both patches, I propose that you decide and > obsolete one of them. :-) Happy to go with what you think is best! Will obselete the first patch :)
Created attachment 46702 [details] [review] Bug 15274: Putting <span> tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable. Signed off on this second patch, see screenshots in comment #4. (Forbidden tab char in line 779 removed) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 release. Thanks!