Bug 15274 - Better translatability for circulation.pl / circulation.tt
Summary: Better translatability for circulation.pl / circulation.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-01 22:11 UTC by Marc Véron
Modified: 2017-06-14 22:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15274: Removing <span> tags from circulation.tt which split the sentence (2.62 KB, patch)
2016-01-15 00:22 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[Alternative Patch] Bug 15274: Putting <span> tags around entire string where the originally split the sentence (2.71 KB, patch)
2016-01-15 00:29 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Screenshots to compare patches (80.65 KB, application/pdf)
2016-01-15 05:11 UTC, Marc Véron
Details
Bug 15274: Putting <span> tags around entire string where the originally split the sentence (2.95 KB, patch)
2016-01-15 05:24 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15274: Removing <span> tags from circulation.tt which split the sentence (2.82 KB, patch)
2016-01-15 05:29 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15274: Putting <span> tags around entire string where the originally split the sentence (3.00 KB, patch)
2016-01-15 15:44 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-01 22:11:41 UTC
In /circ/circulation.pl, the sentence
"Checkouts are BLOCKED because fine balance is OVER THE LIMIT."
translates in German to:
"Ausleihen sind GESPERRT weil Gebührenkonto ist ÜBER BEGRENZUNG."

That is simply wrong, and it is almost impossible to translate correctly because the strings are splitted by html tags.
Comment 1 Aleisha Amohia 2016-01-14 23:23:53 UTC
I suppose we can either take the tags out completely or put the entire string within the tags. I can write a patch for both options
Comment 2 Aleisha Amohia 2016-01-15 00:22:24 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2016-01-15 00:29:04 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-01-15 05:11:01 UTC
Created attachment 46680 [details]
Screenshots to compare patches

I made some screenshots.

For this Bug I would prefer the alternative patch (whole sentence in tags).

Most important thing at the moment is to get rid of the sentence splitting because of the really weird translations.

The whole part with blocking messages can then be streamlined in a separate bug.
Comment 5 Marc Véron 2016-01-15 05:24:44 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2016-01-15 05:29:45 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2016-01-15 05:31:49 UTC
Hi Aleisha, I signed off on both patches, I propose that you decide and obsolete one of them. :-)
Comment 8 Aleisha Amohia 2016-01-15 07:20:18 UTC
(In reply to Marc Véron from comment #7)
> Hi Aleisha, I signed off on both patches, I propose that you decide and
> obsolete one of them. :-)

Happy to go with what you think is best! Will obselete the first patch :)
Comment 9 Kyle M Hall 2016-01-15 15:44:10 UTC
Created attachment 46702 [details] [review]
Bug 15274: Putting <span> tags around entire string where the originally split the sentence

I have only done this where the tags split the sentence.

To test:
1) Go to a borrower's check out page (circulation.pl)
2) Check out a book and specify the due date to a past date (ie, to 2015 etc)
3) Confirm the entire sentence in the error message is styled by the span tags.
4) Create a manual invoice of $100 for the borrower
5) Confirm the entire sentence in the error message styled by span tags.
6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult.

I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable.

Signed off on this second patch, see screenshots in comment #4.
(Forbidden tab char in line 779 removed)
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Brendan Gallagher 2016-01-27 05:59:42 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!