The problem appears when running a SQL report or exporting a SQL report. The column header are in incorrect encoding. Test plan: 1 - Add a new SQL report using the following SQL for example: SELECT borrowers.cardnumber 'Número cartão', CONCAT (borrowers.firstname, ' ' , borrowers.surname) Nome, categories.description Grupo, borrowers.branchcode Biblioteca,borrowers.dateenrolled 'Data de inscrição', borrowers.dateexpiry 'Data limite' FROM borrowers INNER JOIN categories ON borrowers.categorycode = categories.categorycode ORDER BY borrowers.cardnumber ASC 2 - Run the report 3 - The column headers are incorrect. 4 - Export the report to CSV. 5 - The column headers on the file are incorrect.
Created attachment 45353 [details] [review] Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D
(In reply to Tomás Cohen Arazi from comment #1) > - Export the report > => SUCCESS: Encoding correct It doesn't fix the exported files. Followup needed.
(In reply to Tomás Cohen Arazi from comment #2) > (In reply to Tomás Cohen Arazi from comment #1) > > - Export the report > > => SUCCESS: Encoding correct > > It doesn't fix the exported files. Followup needed. Just fail in comma separated in tab separated and open document doesn't fail.
CSV fails. Tab separated text fails. Open Document spreadsheet it's fine.
(In reply to Vitor Fernandes from comment #4) > CSV fails. > Tab separated text fails. > Open Document spreadsheet it's fine. I'm working on it, I found some issues
Created attachment 45384 [details] [review] Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding
Created attachment 45385 [details] [review] Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok
Created attachment 45456 [details] [review] Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Created attachment 45457 [details] [review] Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Created attachment 45501 [details] [review] Bug 15290: (follow-up)SQL reports headers encoding problem Fix SQL row data and headers enconding problem To test: -Apply patches -Follow previous test plan -Notice the headers and row data is displayed in UTF-8 without double encoding -Save in Comma separated text, Tab seprated text, and Open Document. -Verify in the three options the file exported is Ok Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45502 [details] [review] Bug 15290: SQL reports headers encoding problem To test: - Create an SQL report with column names containing UTF characters - Run the report => FAIL: The column names are double encoded - Export the report => FAIL: The column names are double encoded in the exported file - Apply the patch - Re-run the report (reload works) => SUCCESS: Encoding correct - Export the report => SUCCESS: Encoding correct - Sign off :-D Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Linked to bug 11944. Must be backported to 3.22.x and 3.20.x
Patches pushed to master! Thanks Hector and Tomas!
Patches pushed to 3.22.x, will be in 3.22.1
This patch has been pushed to 3.20.x, will be in 3.20.7.