"From" and "To" in members-update.tt are ambiguous and can not be properly translated.(See Bug 15275). Replace them with to make them unambiguous: <th>Field</th> <th>Old value</th> <th>New value</th>
Created attachment 45383 [details] [review] Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense
Created attachment 45388 [details] [review] [SIGNED-OFF]Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purpose
Created attachment 45436 [details] [review] [PASSED QA] Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purpose Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46035 [details] [review] Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt This patch replaces semantically ambigous words "From" and "To" in koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt for better translatability. To test: - Apply patch - Make sure that patrons can request detail changes in OPAC (sysprefs opacuserlogin, OPACPatronDetails) - Log in to OPAC, request a change of personal details (cgi-bin/koha/opac-memberentry.pl) - Log in to staff client - Click link 'Patrons requesting modifications' or go to Home > Patrons > Update patron records - Verify that table headers make sense Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rewording Ok for translation purpose Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to master - Thanks!
Patch pushed in 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.