When viewing authority Z39.50 search results, the "MARC" link should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Created attachment 45463 [details] [review] Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays.
Created attachment 45465 [details] [review] Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Side note: Since there is this contextual menu to view/import biblio records, why do we keep the 2 columns with links MARC/Import?
There is no modal-footer with the close button, is it expected?
(In reply to Jonathan Druart from comment #4) > There is no modal-footer with the close button, is it expected? Yes, I explain in the commit message: > Because the modal is triggered from a pop-up window, the modal has been > reformated to exclude the footer and reduce the size of the modal > header. I think this is an acceptable tradeoff between consistency and readability for these instances when the modal is displayed within a smaller pop-up window.
(In reply to Frédéric Demians from comment #3) > Side note: Since there is this contextual menu to view/import biblio > records, why do we keep the 2 columns with links MARC/Import? I think the context menu is often 'not found' as it's still kind of an unusual element in Koha - I think as the columns are at the end of the table, it doesn'thurt to keep them for now.
Created attachment 45637 [details] [review] Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the authorities Z39.50 search results page so that MARC previews are displayed in Bootstrap modals. This patch also modifies the authorities toolbar include file to make the Z39.50 search popup size match that in cataloging. Because the modal is triggered from a pop-up window, the modal has been reformated to exclude the footer and reduce the size of the modal header. To test: 1. Apply the patch and navigate to Authorities. 2. Click the "New from Z39.50" button to open the search window. 3. Perform any search which will return multiple results. 4. Test the visible "MARC" link for multiple results and confirm that the correct data is shown each time. 5. Click anywhere in the results table to show the hidden menu and test the "MARC" link it displays. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, thanks Owen!
Switching severity to 'enhancement' as the patch does not fix any bug