Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview
Summary: Use Bootstrap modal for authority Z39.50 search results preview
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/z3950_auth_...
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-05 19:38 UTC by Owen Leonard
Modified: 2017-06-14 22:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview (7.78 KB, patch)
2015-12-07 16:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview (7.88 KB, patch)
2015-12-07 16:54 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview (7.96 KB, patch)
2015-12-14 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-05 19:38:56 UTC
When viewing authority Z39.50 search results, the "MARC" link should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-07 16:37:23 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2015-12-07 16:54:32 UTC Comment hidden (obsolete)
Comment 3 Frédéric Demians 2015-12-07 16:56:21 UTC
Side note: Since there is this contextual menu to view/import biblio records, why do we keep the 2 columns with links MARC/Import?
Comment 4 Jonathan Druart 2015-12-11 09:51:22 UTC
There is no modal-footer with the close button, is it expected?
Comment 5 Owen Leonard 2015-12-11 15:38:11 UTC
(In reply to Jonathan Druart from comment #4)
> There is no modal-footer with the close button, is it expected?

Yes, I explain in the commit message:

> Because the modal is triggered from a pop-up window, the modal has been
> reformated to exclude the footer and reduce the size of the modal
> header.

I think this is an acceptable tradeoff between consistency and readability for these instances when the modal is displayed within a smaller pop-up window.
Comment 6 Katrin Fischer 2015-12-13 21:53:54 UTC
(In reply to Frédéric Demians from comment #3)
> Side note: Since there is this contextual menu to view/import biblio
> records, why do we keep the 2 columns with links MARC/Import?

I think the context menu is often 'not found' as it's still kind of an unusual element in Koha - I think as the columns are at the end of the table, it doesn'thurt to keep them for now.
Comment 7 Jonathan Druart 2015-12-14 10:27:07 UTC
Created attachment 45637 [details] [review]
Bug 15316 - Use Bootstrap modal for authority Z39.50 search results preview

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the authorities Z39.50 search results page so that
MARC previews are displayed in Bootstrap modals. This patch also
modifies the authorities toolbar include file to make the Z39.50 search
popup size match that in cataloging.

Because the modal is triggered from a pop-up window, the modal has been
reformated to exclude the footer and reduce the size of the modal
header.

To test:

1. Apply the patch and navigate to Authorities.
2. Click the "New from Z39.50" button to open the search
   window.
3. Perform any search which will return multiple results.
4. Test the visible "MARC" link for multiple results and
   confirm that the correct data is shown each time.
5. Click anywhere in the results table to show the hidden menu and test
   the "MARC" link it displays.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Kyle M Hall 2015-12-30 15:30:17 UTC
Pushed to master, thanks Owen!
Comment 9 Julian Maurice 2016-01-03 11:21:56 UTC
Switching severity to 'enhancement' as the patch does not fix any bug