Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files
Summary: Use Bootstrap modal for MARC and Card preview when ordering from staged files
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/addorderiso2709.pl
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-05 19:40 UTC by Owen Leonard
Modified: 2017-06-14 22:08 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files (5.21 KB, patch)
2015-12-07 14:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files (5.34 KB, patch)
2015-12-07 15:54 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files (5.41 KB, patch)
2015-12-14 12:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-05 19:40:52 UTC
When adding to an order from a staged file, the "MARC" and "Card" links should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-07 14:10:09 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-07 15:54:02 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-11 09:48:41 UTC
Comment on attachment 45455 [details] [review]
Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files

Review of attachment 45455 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
@@ +10,2 @@
>  <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
> +<style type="text/css">#dataPreview { width : 80%; margin-left : -40%; } @media (max-width: 767px) { #dataPreview { margin: 0; width : auto; } }</style>

Why do we need a special style for this one?
Comment 4 Owen Leonard 2015-12-11 15:59:14 UTC
(In reply to Jonathan Druart from comment #3)
> Why do we need a special style for this one?

It's not a special style just for this patch. Others have a similar addition. The default Bootstrap modal isn't very wide. I'd be happy to work on follow-ups to get some of that code consolidated.
Comment 5 Jonathan Druart 2015-12-14 12:33:04 UTC
Created attachment 45642 [details] [review]
Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the page in Acquisitions for ordering from a staged
file so that the "MARC" and "Card" previews display in Bootstrap modals.

To test:

1. Apply the patch and navigate to Acquisitions.
2. Locate an exsiting basket or create a new one.
3. Add to the basket using the option to order from a staged file.
4. Click "Add orders" from any staged file.
5. Test the "MARC" and "Card" links for multiple results and confirm
   that the correct data is shown each time.

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Kyle M Hall 2015-12-30 15:35:07 UTC
Pushed to master, thanks Owen!
Comment 7 Julian Maurice 2016-01-03 11:22:15 UTC
Switching severity to 'enhancement' as the patch does not fix any bug