When adding to an order from a staged file, the "MARC" and "Card" links should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Created attachment 45447 [details] [review] Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time.
Created attachment 45455 [details] [review] Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch>
Comment on attachment 45455 [details] [review] Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files Review of attachment 45455 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +10,2 @@ > <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> > +<style type="text/css">#dataPreview { width : 80%; margin-left : -40%; } @media (max-width: 767px) { #dataPreview { margin: 0; width : auto; } }</style> Why do we need a special style for this one?
(In reply to Jonathan Druart from comment #3) > Why do we need a special style for this one? It's not a special style just for this patch. Others have a similar addition. The default Bootstrap modal isn't very wide. I'd be happy to work on follow-ups to get some of that code consolidated.
Created attachment 45642 [details] [review] Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, thanks Owen!
Switching severity to 'enhancement' as the patch does not fix any bug