Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source
Summary: Use Bootstrap modal for MARC and Card preview when ordering an external source
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/z3950_search.pl
Keywords:
Depends on:
Blocks: 8290
  Show dependency treegraph
 
Reported: 2015-12-05 19:42 UTC by Owen Leonard
Modified: 2016-12-05 21:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source (8.05 KB, patch)
2015-12-07 15:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source (8.18 KB, patch)
2015-12-07 15:29 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source (8.25 KB, patch)
2015-12-11 09:38 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-05 19:42:33 UTC
When adding to an order from an external source, the "MARC" and "Card" links on the search results list should trigger a preview in a Bootstrap modal instead of a Greybox modal.
Comment 1 Owen Leonard 2015-12-07 15:17:24 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-07 15:29:46 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-11 09:38:31 UTC
Created attachment 45585 [details] [review]
Bug 15318 - Use Bootstrap modal for MARC and Card preview when ordering an external source

In order to reduce the number of dependencies for common interactions we
should attempt to use Bootstrap modals in place of Greybox ones.

This patch modifies the page in Acquisitions for ordering from an
external source so that the "MARC" and "Card" previews display in
Bootstrap modals.

This patch also fixes a bug where the in-table popup menu points to the
wrong record (fixed in Cataloging by Bug 6367).

To test:

1. Apply the patch and navigate to Acquisitions.
2. Locate an exsiting basket or create a new one.
3. Add to the basket using the option to order from an external source..
4. Perform a search which will return multiple results.
5. Test the "MARC" and "Card" links for multiple results and confirm
   that the correct data is shown each time.
6. Click anywhere in the results table to show the hidden menu and test
   the "MARC" and "Card" links it displays, confirming that the data
   looks correct and corresponds correctly to the title you selected.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2015-12-11 09:41:14 UTC
Owen, I am a bit worried about the 2 blocks which are copy/paste on every page (the js (on click/hidden) and the tt (dataPreview)).
I don't plan to block them for that, but it would be great to refactore them later.
Comment 5 Kyle M Hall 2015-12-30 15:16:53 UTC
Pushed to master, thanks Owen!
Comment 6 Julian Maurice 2016-01-03 11:22:33 UTC
Switching severity to 'enhancement' as the patch does not fix any bug