Bug 15327 - Minor tweaks to Bootstrap modal handling on Staged MARC management page
Summary: Minor tweaks to Bootstrap modal handling on Staged MARC management page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/manage-marc-impor...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-07 17:06 UTC by Owen Leonard
Modified: 2017-06-14 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15327 - Minor tweaks to Bootstrap modal handling on Staged MARC management page (2.44 KB, patch)
2015-12-07 17:16 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page (2.52 KB, patch)
2015-12-07 20:39 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page (2.57 KB, patch)
2015-12-08 10:27 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2015-12-07 17:06:50 UTC
I have a few tweaks to the way the Bootstrap modal is handled on Staged MARC management page.

- Use the prettier "html" format for the data preview
- Remove some obsolete code left over from when the page used Greybox
Comment 1 Owen Leonard 2015-12-07 17:16:40 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-07 20:39:51 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-08 10:27:57 UTC
Created attachment 45485 [details] [review]
Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page

This patch makes a couple of minor corrections to the template for
staged MARC management. The MARC preview is now formatted using the
"html" option, and some obsolete Greybox-related code has been removed.

To test:

1. Apply the patch and go to Tools -> Staged MARC management.
2. Click any staged MARC file containing multiple records.
3. Click the title in the "Citation" column and confirm that a Bootstrap
   modal is triggered showing the correct data.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Modal looks much better. Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2015-12-30 14:43:26 UTC
Pushed to master, thanks Owen!
Comment 5 Julian Maurice 2015-12-31 10:20:56 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 6 Frédéric Demians 2015-12-31 18:32:02 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.