I have a few tweaks to the way the Bootstrap modal is handled on Staged MARC management page. - Use the prettier "html" format for the data preview - Remove some obsolete code left over from when the page used Greybox
Created attachment 45467 [details] [review] Bug 15327 - Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data.
Created attachment 45472 [details] [review] [SIGNED-OFF]Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Modal looks much better. Works as advertised
Created attachment 45485 [details] [review] Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Modal looks much better. Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master, thanks Owen!
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.