For historical reasons the SIPServer has not been located in the bin directory but in the lib hierarchical - these reasons no longer apply and this is only a source of confusion and "special case" workarounds. Relocate the server to its logical place in the hierarchy
Created attachment 45525 [details] [review] Proposed patch Testing: Using the amended start up and shutdown scripts the server should behave as before this patch was applied
Created attachment 45526 [details] [review] Supplementary patch Supplementary patch removes obsolete comments and applies consistent formatting to the code. Adds a comment to indicate Net::Server::Fork is a valid alternative to PreFork
Applying: Bug 15338 move SIPServer to bin directory fatal: sha1 information is lacking or useless (C4/SIP/SIPServer.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15338 move SIPServer to bin directory
Created attachment 119002 [details] [review] Bug 15338: Move SIPServer to bin directory SIPServer should reside like other programs in the bin directory rather than lurking in modules removed the pm suffix which confused some users sip_run.sh can now be simplified and not fail because of misuse of path definition as a directory removed the unnecessary sourcing of .bash_profile in shutdown (what if you dont have a bash_profile?) SIP modules are now in standard lib path so Server does not need to set its own lib
Created attachment 119003 [details] [review] Bug 15338: Fix indentation and comments in SIPServer Supplemental patch which takes advantage of the relocation of the program to apply a consistent indentation to the code also removes comments arising from the confusion resulting from the program's name and location Add a comment indicating that this code will work under other flavours of Net::Server as well as PreFork
No longer applies cleanly to master