To verify: - make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose'
Created attachment 45533 [details] [review] Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag This patch fixes a translatability issue due to <trong> tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' To test: - Apply patch - Verify that the <strong> tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc
Created attachment 45534 [details] [review] Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag This patch fixes a translatability issue due to <trong> tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' To test: - Apply patch - Verify that the <strong> tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Obvious issue/solution
Created attachment 45595 [details] [review] Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag This patch fixes a translatability issue due to <trong> tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' To test: - Apply patch - Verify that the <strong> tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Obvious issue/solution Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to Master - Thanks
Patch pushed to 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.