Bug 15340 - Translatability: fix issue with 'or choose' splitted by <strong tag
Summary: Translatability: fix issue with 'or choose' splitted by <strong tag
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-09 15:07 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag (2.72 KB, patch)
2015-12-09 15:17 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag (2.79 KB, patch)
2015-12-09 15:29 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag (2.87 KB, patch)
2015-12-11 10:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-09 15:07:02 UTC
To verify:
- make sure that you have some entries in 'Cities and Towns'
  ( Home > Administration > Cities )
- Edit the main address of a patron's details
- Locate field "City", at the right you have the text 'or choose'
  followed by a drop-down ('choose' is bold)
- change language e.g. to German, the text reads 'or auswählen' 
  (instead of 'oder auswählen')
- This is due to the <strong> tags around 'choose'
Comment 1 Marc Véron 2015-12-09 15:17:09 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2015-12-09 15:29:11 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-11 10:26:03 UTC
Created attachment 45595 [details] [review]
Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag

This patch fixes a translatability issue due to <trong> tags.

To verify:
- Make sure that you have some entries in 'Cities and Towns'
  ( Home > Administration > Cities )
- Edit the main address of a patron's details
- Locate field "City", at the right you have the text 'or choose'
  followed by a drop-down ('choose' is bold)
- change language e.g. to German, the text reads 'or auswählen'
  (instead of 'oder auswählen')
- This is due to the <strong> tags around 'choose'

To test:
- Apply patch
- Verify that the <strong> tags around 'choose' are removed in:
    koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc
    koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  Obvious issue/solution

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Brendan Gallagher 2015-12-30 19:10:25 UTC
Pushed to Master - Thanks
Comment 5 Julian Maurice 2015-12-31 13:22:14 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 6 Frédéric Demians 2015-12-31 18:33:25 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.