Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert.
Created attachment 45558 [details] [review] Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. To test: - Apply patch - To trigger the messages, you have to edit a patron in a system where no libraries and no patron categories are defined - Alternatively, carefully review the changes in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Created attachment 45559 [details] [review] [SIGNED-OFF]Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. To test: - Apply patch - To trigger the messages, you have to edit a patron in a system where no libraries and no patron categories are defined - Alternatively, carefully review the changes in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Sentences fixed for translation purposes
Created attachment 45562 [details] [review] Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. To test: - Apply patch - To trigger the messages, you have to edit a patron in a system where no libraries and no patron categories are defined - Alternatively, carefully review the changes in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Sentences fixed for translation purposes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46029 [details] [review] Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. To test: - Apply patch - To trigger the messages, you have to edit a patron in a system where no libraries and no patron categories are defined - Alternatively, carefully review the changes in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Sentences fixed for translation purposes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to Master - Thanks!
Patch pushed in 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.