Bug 15346 - Translatability: fix sentence splitting issue in memberentrygen.tt
Summary: Translatability: fix sentence splitting issue in memberentrygen.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-09 20:30 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt (2.86 KB, patch)
2015-12-09 20:40 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt (2.97 KB, patch)
2015-12-10 01:50 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt (3.03 KB, patch)
2015-12-10 12:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt (3.09 KB, patch)
2015-12-29 20:26 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-09 20:30:49 UTC
Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.
Comment 1 Marc Véron 2015-12-09 20:40:05 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-10 01:50:55 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-10 12:04:09 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2015-12-29 20:26:56 UTC
Created attachment 46029 [details] [review]
Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt

Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to
wrong capitalization in German (because it can not be decided if a string is part
of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.

To test:
- Apply patch
- To trigger the messages, you have to edit a patron in a system where
  no libraries and no patron categories are defined
- Alternatively, carefully review the changes in
  koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Sentences fixed for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 5 Brendan Gallagher 2015-12-29 20:27:37 UTC
Pushed to Master - Thanks!
Comment 6 Julian Maurice 2015-12-30 16:00:29 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:23:39 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.