When viewing an authority using detail.pl, the "New from Z39.50" Button does not generate a new record, but replaces the currently viewed record. This is different behavior than in previous versions. It seems it should generate a new authority record (similar to what is found on the biblio cataloging page), given the text "New", just as it formerly did. If the new behavior is meant, it should be relabeled "Replace using Z39.50" or something similar to avoid destroying authority records and possibly causing database-wide changes by unintentionally replacing a record, and populating that record onto many biblios. Personally, I would favor the former behavior -- generate a new authority record from a Z39.50 search, and leave the button on the editing section in authorities.pl as the method for replacing via a Z39.50 search.
Created attachment 46261 [details] [review] Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" If the record exist, the button text should not be "New from", but "Replace". Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50"
Created attachment 46273 [details] [review] Bug 15360: Rename "New from Z39.50" with "Replace with Z39.50" If the record exist, the button text should not be "New from", but "Replace". Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" Followed test plan, displays as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Perhaps this would qualify as an "enhancement", but would it be possible to restore the older behavior as well? Previously the "New from z39.50" button did exactly that. It generated a new record from a z39.50 authorities search. There was never a "Replace" function or button. The replace feature is great, and allowing replacement as this patch does is a good idea, but perhaps we should also allow the creation of a new record as before. That would require a new "New from z39.50" button which would actually generate a new record, in addition to the "Replace from z39.50". Being on vacation, I'm not in front of my test server, else I'd work up a quick and dirty solution, since it seems easy and straight-forward. Perhaps if someone else has a few minutes ... Thanks for the work to fix and clarify this.
Created attachment 46308 [details] [review] [ALTERNATIVE-PATCH] Bug 15360: Add a "Replace with Z39.50" button when editing an authority If the record exist, a new button "Replace with Z39.50" is added Test plan: Go on the authority home page (authorities/authorities-home.pl) You should see a "New from Z39.50" button. Edit an authority You should now see "Replace with Z39.50" and "New from Z39.50" Confirm that the 2 buttons work as expected.
There are 2 patches now, pick the one you prefer.
*** Bug 15328 has been marked as a duplicate of this bug. ***
Patch doesn't apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc Failed to merge in the changes. Patch failed at 0001 Bug 15360: Add a "Replace with Z39.50" button when editing an authority
Oops sorry, I realise now these patches are meant to be alternatives and tested separately.
I want to sign off on the alternative patch but the 'New from Z39.50' button now doesn't fit along the same line as the other buttons and would look much better if it did. Will sign off once that's fixed up.
(In reply to Aleisha Amohia from comment #9) > I want to sign off on the alternative patch but the 'New from Z39.50' button > now doesn't fit along the same line as the other buttons and would look much > better if it did. Will sign off once that's fixed up. I don't get that, everything looks correct for me.
Created attachment 46565 [details] Button on next line This is what happens for me.
I am also having the same problem as Aleisha where they aren't on the same line
Hm, not obvious to me how to fix that - adding Owen for an opinion about how to fix up the toolbar. (see screenshot attached)
Created attachment 75703 [details] [review] Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button This patch makes a third stab at resolving this issue by reorganizing the authorities toolbar buttons to more closely match the bibliographic toolbar buttons: - "New from Z39.50" has been added to the "New authority" dropdown. - "Edit" is now a dropdown, like on the bibliographic detail page: - Edit record - Edit as new (duplicate) - Replace record via Z39.50/SRU - Delete record To test, apply the patch and go to the authorities module. Testing with existing Z39.50 authority sources configured: - On the authorities home page and the authorities search results page, the "New authority" menu should have a "New from Z39.50" link. - View the details for an authority record. The menus should appear as described above. Test each option. Remove all Z39.50 authority servers and test again. The "New from Z39.50" link should no longer appear.
Created attachment 76584 [details] [review] Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button This patch makes a third stab at resolving this issue by reorganizing the authorities toolbar buttons to more closely match the bibliographic toolbar buttons: - "New from Z39.50" has been added to the "New authority" dropdown. - "Edit" is now a dropdown, like on the bibliographic detail page: - Edit record - Edit as new (duplicate) - Replace record via Z39.50/SRU - Delete record To test, apply the patch and go to the authorities module. Testing with existing Z39.50 authority sources configured: - On the authorities home page and the authorities search results page, the "New authority" menu should have a "New from Z39.50" link. - View the details for an authority record. The menus should appear as described above. Test each option. Remove all Z39.50 authority servers and test again. The "New from Z39.50" link should no longer appear. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 76606 [details] [review] Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button This patch makes a third stab at resolving this issue by reorganizing the authorities toolbar buttons to more closely match the bibliographic toolbar buttons: - "New from Z39.50" has been added to the "New authority" dropdown. - "Edit" is now a dropdown, like on the bibliographic detail page: - Edit record - Edit as new (duplicate) - Replace record via Z39.50/SRU - Delete record To test, apply the patch and go to the authorities module. Testing with existing Z39.50 authority sources configured: - On the authorities home page and the authorities search results page, the "New authority" menu should have a "New from Z39.50" link. - View the details for an authority record. The menus should appear as described above. Test each option. Remove all Z39.50 authority servers and test again. The "New from Z39.50" link should no longer appear. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.02
Patch does not apply easily on 17.11.x. If back-port is possible, please provide a rebased patch.
(In reply to Fridolin SOMERS from comment #19) > If back-port is possible, please provide a rebased patch. The patch would have to be largely re-written, so I'm inclined to let it go unless someone wants to twist my arm.
Ok let it go, let it go ...