Bug 15362 - Translatability: Fix issue on Administration 'Did you mean?'
Summary: Translatability: Fix issue on Administration 'Did you mean?'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 09:47 UTC by Marc Véron
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?' (2.28 KB, patch)
2015-12-13 09:54 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15362: Translatability: Fix issue on Administration 'Did you mean?' (2.41 KB, patch)
2015-12-14 15:56 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?' (2.46 KB, patch)
2015-12-18 10:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?' (2.53 KB, patch)
2015-12-29 20:31 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-13 09:47:34 UTC
Fix sentence splitting by tags on didyoumean.tt leading to odd translations.
Comment 1 Marc Véron 2015-12-13 09:54:18 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-14 15:56:03 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-18 10:04:00 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2015-12-29 20:31:51 UTC
Created attachment 46031 [details] [review]
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?'

Fix sentence splitting by tags on didyoumean.tt leading to odd translations.

To test:
- Apply patch
- Go to Home > Administration > Did you mean?
- Verify that the information below the title displays properly and makes sense.
- Disable Javascript, reload page
- Verify that the warning about missing Javascript displays properly and makes sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived. Removed em tags for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 5 Brendan Gallagher 2015-12-29 20:32:07 UTC
Pushed to Master - Thanks!
Comment 6 Julian Maurice 2015-12-30 16:03:50 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:24:07 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.