Bug 15365 - Translatability: Fix issue on Administration > Circulation and fine rules
Summary: Translatability: Fix issue on Administration > Circulation and fine rules
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 19:33 UTC by Marc Véron
Modified: 2017-06-14 22:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules (2.08 KB, patch)
2015-12-13 19:41 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules (2.11 KB, patch)
2015-12-13 19:44 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules (2.24 KB, patch)
2015-12-14 15:36 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules (2.29 KB, patch)
2015-12-18 10:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules (2.36 KB, patch)
2015-12-29 20:42 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-13 19:33:23 UTC
Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines).
Comment 1 Marc Véron 2015-12-13 19:41:28 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-12-13 19:44:23 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2015-12-14 15:36:02 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-12-15 09:06:51 UTC
This is a bug in the translation process, em and string tags should not be isolated, IMO.
I have tried to fix it, but no luck.
Frédéric, do you think this could be done easily?
Comment 5 Jonathan Druart 2015-12-18 10:10:53 UTC Comment hidden (obsolete)
Comment 6 Brendan Gallagher 2015-12-29 20:42:59 UTC
Created attachment 46033 [details] [review]
Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules

Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences
splitted by tags and newlines).

To test:
- Apply patch
- Go to Administration > Circulation and fine rules
- Verify that the lines "Note: " and "Important: " below "Default holds policy by
  item type" make sense and are not splitted by tags and (in html) by newlines.

(Amended to fix commit message)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
strong Note and Important displayed Ok for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 7 Brendan Gallagher 2015-12-29 20:43:14 UTC
Pushed to master - thanks!
Comment 8 Julian Maurice 2015-12-30 16:05:55 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 9 Frédéric Demians 2015-12-31 18:24:33 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.