Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines).
Created attachment 45619 [details] [review] Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policx by item type" make sense and are not splitted by tags and (in html) by newlines.
Created attachment 45620 [details] [review] Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message)
Created attachment 45664 [details] [review] [SIGNED-OFF]Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> strong Note and Important displayed Ok for translation purpose
This is a bug in the translation process, em and string tags should not be isolated, IMO. I have tried to fix it, but no luck. Frédéric, do you think this could be done easily?
Created attachment 45806 [details] [review] Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> strong Note and Important displayed Ok for translation purpose Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 46033 [details] [review] Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> strong Note and Important displayed Ok for translation purpose Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Pushed to master - thanks!
Patch pushed in 3.22.x, will be in 3.22.2
This patch has been pushed to 3.20.x, will be in 3.20.8.