Bug 15366 - Fix breadcrumbs and html page title in guided reports
Summary: Fix breadcrumbs and html page title in guided reports
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-13 21:39 UTC by Marc Véron
Modified: 2017-06-14 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15366 - Fix breadcrumbs and html page title in guided reports (5.97 KB, patch)
2015-12-13 21:47 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFf]Bug 15366 - Fix breadcrumbs and html page title in guided reports (6.05 KB, patch)
2015-12-14 15:49 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15366 - Fix breadcrumbs and html page title in guided reports (6.11 KB, patch)
2015-12-18 10:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15366 - Fix breadcrumbs and html page title in guided reports (6.17 KB, patch)
2015-12-29 20:45 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2015-12-13 21:39:09 UTC
Fix issues with breadcrumbs and html page title in Home > Reports > Guided reports wizard.
- Sometimes, breadcrumbs display a stray > at the end
- While creating a report, steps are not displayed in breadcrumbs and do not appear in html page title
- html page title is divided by newlines
Comment 1 Marc Véron 2015-12-13 21:47:47 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2015-12-14 15:49:12 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2015-12-18 10:00:47 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2015-12-29 20:45:38 UTC
Created attachment 46034 [details] [review]
Bug 15366 - Fix breadcrumbs and html page title in guided reports

This patch fixes following issues with breadcrumbs and html page title
in Home > Reports > Guided reports wizard:

- Sometimes, breadcrumbs display a stray > at the end

- While creating a report, steps are not displayed in breadcrumbs and
  do not appear in html page title
- html page title is divided by newlines

To test:
- Apply patch
- Go to Home > Reports > Guided reports wizard
- Go to all pages including the steps for creating a new report and
  verify
  - that the breadcrumbs display properly and make sense
  - in html source, the page title makes sense and displays on one line.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Comment 5 Brendan Gallagher 2015-12-29 20:45:54 UTC
Pushed to master - Thanks!
Comment 6 Julian Maurice 2015-12-30 16:06:42 UTC
Patch pushed in 3.22.x, will be in 3.22.2
Comment 7 Frédéric Demians 2015-12-31 18:24:47 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.