Bug 15373 - Zip should be ZIP
Summary: Zip should be ZIP
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-14 22:17 UTC by Aleisha Amohia
Modified: 2017-06-14 22:07 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15373: Changing Zip to ZIP on OPAC and Intranet (11.74 KB, patch)
2015-12-14 22:48 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Signed-off patch for 15373 (11.81 KB, patch)
2015-12-16 15:47 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 15373: More changes of Zip to ZIP on intranet (10.05 KB, patch)
2015-12-20 20:07 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15373: Changing Zip to ZIP on OPAC and Intranet (11.88 KB, patch)
2015-12-30 00:41 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15373: More changes of Zip to ZIP on intranet (10.13 KB, patch)
2015-12-30 00:41 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15373: Changing Zip to ZIP on OPAC and Intranet (11.95 KB, patch)
2015-12-30 11:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15373: More changes of Zip to ZIP on intranet (10.21 KB, patch)
2015-12-30 11:18 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-12-14 22:17:00 UTC
ZIP is an acronym (Zone Improvement Plan) so Zip should be replaced to ZIP in OPAC and Staff Interface
Comment 1 Aleisha Amohia 2015-12-14 22:48:52 UTC Comment hidden (obsolete)
Comment 2 Barry Cannon 2015-12-16 15:25:59 UTC
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt
Comment 3 Barry Cannon 2015-12-16 15:47:52 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2015-12-17 21:45:07 UTC
I think small mistake here - switching to Signed off
Comment 5 Jonathan Druart 2015-12-18 09:52:08 UTC
I have found more occurrences in the following files:
koha-tmpl/intranet-tmpl/prog/en/columns.def
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref
koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
reports/borrowers_stats.pl
Comment 6 Aleisha Amohia 2015-12-20 20:07:41 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2015-12-30 00:28:08 UTC
This is not an enhancement. It is annoying that enhancement is the default, and we sometimes forget to check for it. This is a string correction. Simple enough to check.

I have confirmed that all instances seem to be dealt with. Now to follow test plan.

Aleisha, if you are submitting the patch, please remember to take the bug.
Comment 8 Mark Tompsett 2015-12-30 00:41:35 UTC Comment hidden (obsolete)
Comment 9 Mark Tompsett 2015-12-30 00:41:43 UTC Comment hidden (obsolete)
Comment 10 Jonathan Druart 2015-12-30 11:18:02 UTC
Created attachment 46068 [details] [review]
Bug 15373: Changing Zip to ZIP on OPAC and Intranet

To test:

1) Login to OPAC --> You personal details.
2) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact
3) Login to Staff interface --> Go to a member's page (ie koha/members/memberentry.pl) --> Details.
4) Ensure it says 'ZIP/Postal Code' under Alternate address and Alternative contact
5) Click Edit
6) Ensure it says 'ZIP/Postal Code' under Main Address, Alternate Address and Alternate Contact

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Tested together with second patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2015-12-30 11:18:05 UTC
Created attachment 46069 [details] [review]
Bug 15373: More changes of Zip to ZIP on intranet

To test:

- Log in to Staff Interface, go to Administration, Libraries and Groups (cgi-bin/koha/admin/branches.pl). Click 'New library' and confirm that it says 'ZIP/Postal Code:' in the form.
- Go back to Administration, Cities and towns (cgi-bin/koha/admin/cities.pl). Confirm it says 'ZIP/Postal code' in table heading. Click 'New city' and confirm it says 'ZIP/Postal code:' in form
- Go back to Administration, Global system preferences, I18L/L10N (cgi-bin/koha/admin/preferences.pl?tab=i18n_l10n). Under AddressFormat, confirm all available options say '[ZIP/Postal Code]'
- Go to Reports, Patrons (cgi-bin/koha/reports/borrowers_stats.pl). Confirm it says 'ZIP/Postal code' under Title
- Go to Tools, Batch patron modification (cgi-bin/koha/tools/modborrowers.pl), enter any card number and click 'Continue'. Confirm it says 'ZIP/Postal code' in the table of patron details, and in the form to edit

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Tested together with first patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Kyle M Hall 2015-12-30 16:33:22 UTC
Pushed to master, thanks Aleisha!
Comment 13 Julian Maurice 2015-12-31 13:15:30 UTC
Patches pushed to 3.22.x, will be in 3.22.2
Comment 14 Frédéric Demians 2015-12-31 18:32:37 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.