The term "non fiction" is incorrect. Writing a patch which will change "non fiction" to "non-fiction" everywhere in OPAC and Staff Client. I would rather change to "nonfiction" rather than "non-fiction" because eliminating the hyphen takes no meaning away from the term, saves space and uses less characters, and solidifies the term. However Koha uses "non-musical recording" etc, so for consistency's sake, I'll use "non-fiction".
Created attachment 45920 [details] [review] Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading
This is a simple patch, not an enhancement. Changed report settings accordingly.
$ git grep -i "non fiction" | grep -v "\/po\/" Please correct Italian, Polish, and Staff client catalogue help files. koha qa test tools passed. Currently does all that is described. However, because of the three files which still need updating, marking Failed QA.
Created attachment 46289 [details] [review] Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file.
Created attachment 46295 [details] [review] Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46296 [details] [review] Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46297 [details] [review] Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. > delete from auth_vals; > source {appropriate file}; 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46298 [details] [review] Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46299 [details] [review] Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. > delete from auth_vals; > source {appropriate file}; 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 46350 [details] [review] [PASSED QA] Bug 15411: Changing 'Non fiction' to 'Non-fiction' To test: 1) Apply patch 2) Run updatedatabase.pl 3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl) 4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits' 5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl) 6) Confirm that it says 'Non-fiction' under 'Collection code' 7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options' 8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu 9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab 10) Confirm that it says 'Non-fiction' under 'Collection' heading Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 46351 [details] [review] [PASSED QA] Bug 15411: More changes Changes to Italian and Polish sql files and catalogue help file. TEST PLAN --------- 1) Confirm sql is valid and has Non-fiction. > delete from auth_vals; > source {appropriate file}; 2) Staff -> Search -> Help -- Confirm Non-fiction 3) Run koha qa test tools Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master, thanks for your work.
Patches pushed to 3.22.x, will be in 3.22.4
This patch has been pushed to 3.20.x, will be in 3.20.9.