Bug 15411 - "Non fiction" is incorrect
Summary: "Non fiction" is incorrect
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-22 20:25 UTC by Aleisha Amohia
Modified: 2017-06-14 22:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15411: Changing 'Non fiction' to 'Non-fiction' (5.59 KB, patch)
2015-12-22 21:58 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15411: More changes (3.42 KB, patch)
2016-01-06 00:23 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15411: Changing 'Non fiction' to 'Non-fiction' (5.62 KB, patch)
2016-01-06 01:15 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15411: Changing 'Non fiction' to 'Non-fiction' (5.62 KB, patch)
2016-01-06 01:19 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15411: More changes (3.66 KB, patch)
2016-01-06 01:19 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15411: Changing 'Non fiction' to 'Non-fiction' (5.62 KB, patch)
2016-01-06 01:24 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 15411: More changes (3.66 KB, patch)
2016-01-06 01:24 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 15411: Changing 'Non fiction' to 'Non-fiction' (5.69 KB, patch)
2016-01-06 20:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 15411: More changes (3.73 KB, patch)
2016-01-06 20:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-12-22 20:25:03 UTC
The term "non fiction" is incorrect. Writing a patch which will change "non fiction" to "non-fiction" everywhere in OPAC and Staff Client. 

I would rather change to "nonfiction" rather than "non-fiction" because eliminating the hyphen takes no meaning away from the term, saves space and uses less characters, and solidifies the term. However Koha uses "non-musical recording" etc, so for consistency's sake, I'll use "non-fiction".
Comment 1 Aleisha Amohia 2015-12-22 21:58:26 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2015-12-29 23:56:20 UTC
This is a simple patch, not an enhancement. Changed report settings accordingly.
Comment 3 Mark Tompsett 2015-12-30 00:17:33 UTC
$ git grep -i "non fiction" | grep -v "\/po\/"

Please correct Italian, Polish, and Staff client catalogue help files.

koha qa test tools passed.
Currently does all that is described.
However, because of the three files which still need updating, marking Failed QA.
Comment 4 Aleisha Amohia 2016-01-06 00:23:21 UTC Comment hidden (obsolete)
Comment 5 Mark Tompsett 2016-01-06 01:15:28 UTC Comment hidden (obsolete)
Comment 6 Mark Tompsett 2016-01-06 01:19:00 UTC Comment hidden (obsolete)
Comment 7 Mark Tompsett 2016-01-06 01:19:06 UTC Comment hidden (obsolete)
Comment 8 Mark Tompsett 2016-01-06 01:24:36 UTC Comment hidden (obsolete)
Comment 9 Mark Tompsett 2016-01-06 01:24:43 UTC Comment hidden (obsolete)
Comment 10 Katrin Fischer 2016-01-06 20:19:03 UTC
Created attachment 46350 [details] [review]
[PASSED QA] Bug 15411: Changing 'Non fiction' to 'Non-fiction'

To test:

1) Apply patch
2) Run updatedatabase.pl
3) Go to advanced search in Staff Client (ie /cgi-bin/koha/catalogue/search.pl)
4) Confirm that it says 'Non-fiction' in the 'Any content' drop-down menu under 'Subtype limits'
5) Go to item search (ie /cgi-bin/koha/catalogue/itemsearch.pl)
6) Confirm that it says 'Non-fiction' under 'Collection code'
7) Go to advanced search in OPAC (ie /cgi-bin/koha/opac-search.pl) and click 'More options'
8) Confirm that it says 'Non-fiction' in the 'Content' drop-down menu
9) Go to the details page for a non-fiction book in the OPAC (ie /cgi-bin/koha/opac-detail.pl?biblionumber=2) and click 'Holdings' tab
10) Confirm that it says 'Non-fiction' under 'Collection' heading

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2016-01-06 20:19:41 UTC
Created attachment 46351 [details] [review]
[PASSED QA] Bug 15411: More changes

Changes to Italian and Polish sql files and catalogue help file.

TEST PLAN
---------
1) Confirm sql is valid and has Non-fiction.
   > delete from auth_vals;
   > source {appropriate file};
2) Staff -> Search -> Help
   -- Confirm Non-fiction
3) Run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Jesse Weaver 2016-02-12 23:54:53 UTC
Pushed to master, thanks for your work.
Comment 13 Julian Maurice 2016-02-15 08:02:45 UTC
Patches pushed to 3.22.x, will be in 3.22.4
Comment 14 Frédéric Demians 2016-02-20 08:54:44 UTC
This patch has been pushed to 3.20.x, will be in 3.20.9.