Bug 15413 - Adding colons where they should appear in forms etc to be consistent
Summary: Adding colons where they should appear in forms etc to be consistent
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-22 22:17 UTC by Aleisha Amohia
Modified: 2023-06-09 08:52 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15413: Adding colons where appropriate (34.82 KB, patch)
2015-12-22 23:19 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15413: Adding colons where appropriate (29.33 KB, patch)
2016-03-24 14:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 15413: Adding colons where appropriate (29.35 KB, patch)
2016-03-24 22:03 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-12-22 22:17:07 UTC

    
Comment 1 Aleisha Amohia 2015-12-22 23:19:38 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2015-12-22 23:19:56 UTC
Something for a rainy day :)
Comment 3 Owen Leonard 2016-03-24 14:45:42 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-03-24 22:03:56 UTC
Created attachment 49567 [details] [review]
Bug 15413: Adding colons where appropriate

To test:

Apply patch and go to pretty much every page on the Intranet - look out
for labels on forms etc where there should be colons but aren't. If you
see any that I've missed but I'm 99% sure I got all of them! Make sure
to click through some forms where creating a new thing involves
continuing the submission on multiple pages.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Rebased on current master and checked all changed pages.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2016-03-24 22:04:20 UTC
These ones may be missing:

  23 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt:            <span class="label">Title</span>
  29 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt:            <label for="invoice">Vendor invoice </label>
  32 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:        <p><span class="label">Primary acquisitions contact</span></p>
  33 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:        <p><span class="label">Primary serials contact</span></p>
  34 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:        <p><span class="label">Receives claims for late orders</span></p     >
  35 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt:        <p><span class="label">Receives claims for late issues</span></p     >
Comment 6 Brendan Gallagher 2016-03-25 21:51:26 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!