Bug 15471 - Add column settings and filters to Holds queue table
Summary: Add column settings and filters to Holds queue table
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Testopia
URL:
Keywords:
Depends on: 15285
Blocks: 20530
  Show dependency treegraph
 
Reported: 2016-01-05 14:29 UTC by Julian Maurice
Modified: 2018-04-05 17:14 UTC (History)
13 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15471: Add column settings and filters to Holds queue table (7.40 KB, patch)
2016-01-05 14:29 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15471: Add column settings and filters to Holds queue table (7.35 KB, patch)
2016-01-06 09:08 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 15471: Add column settings and filters to Holds queue table (7.53 KB, patch)
2016-01-06 10:26 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15471: Add column settings and filters to Holds queue table (7.58 KB, patch)
2016-02-05 12:33 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15471 [QA Followup] - Fix error causing visibility button to not display (1.18 KB, patch)
2016-02-05 12:33 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2016-01-05 14:29:16 UTC
Add column visibility menu and a text filter on top of each column for the holds queue table
Comment 1 Julian Maurice 2016-01-05 14:29:47 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-05 17:43:41 UTC
QA tools say:
 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
   FAIL	  forbidden patterns
		forbidden pattern: console.log (line 25)
Comment 3 Marc Véron 2016-01-05 17:46:48 UTC
Oh, sorry, I was not aware of the dependency: Bug 15285.
Patch seems to work, though, behalve of the QA tools complaining (see comment #2)
Comment 4 Julian Maurice 2016-01-06 09:08:14 UTC Comment hidden (obsolete)
Comment 5 Julian Maurice 2016-01-06 09:09:32 UTC
(In reply to Marc Véron from comment #2)
> QA tools say:
>  FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: console.log (line 25)

Sorry about that, this is fixed now
Comment 6 Marc Véron 2016-01-06 10:23:36 UTC
Filtering works OK and I can manage the columns in administration, but I do not see a 'Show / hide columns' on the  page itself (like e.g. with the currency table).

Should the patch be tested on top of 15285?
Comment 7 Marc Véron 2016-01-06 10:26:52 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall 2016-02-05 12:33:39 UTC
Created attachment 47692 [details] [review]
Bug 15471: Add column settings and filters to Holds queue table

Add column visibility menu using DataTables Buttons
Add a text filter on top of each column
Also extend page width so that the large table is better centered

Depends on bug 15285

Test plan
1. Go to Holds queue page (circ/view_holdsqueue.pl)
2. Check that table sorting and filtering work well and that you can
   hide each column
3. Go to Admin > Configure columns and change the settings for this
   table (Circulation > view_holdsqueue > holds-table). Verify that the
   settings work by going again to the Holds queue page
4. Check that filters continue to work after hiding some columns

Tested on top of 15285, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2016-02-05 12:33:54 UTC
Created attachment 47693 [details] [review]
Bug 15471 [QA Followup] - Fix error causing visibility button to not display

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Brendan Gallagher 2016-02-24 04:14:12 UTC
Pushed to Master - Should be in the may 2016 release.  thanks
Comment 11 Owen Leonard 2016-02-24 17:55:46 UTC
(In reply to Kyle M Hall from comment #9)

> Bug 15471 [QA Followup] - Fix error causing visibility button to not display

In my system this follow-up causes an error rather than fixing one.

SyntaxError: expected expression, got ';'
/cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1

Line 269:

var columns_settings = ;
Comment 12 Jonathan Druart 2016-02-28 22:40:52 UTC
(In reply to Owen Leonard from comment #11)
> (In reply to Kyle M Hall from comment #9)
> 
> > Bug 15471 [QA Followup] - Fix error causing visibility button to not display
> 
> In my system this follow-up causes an error rather than fixing one.
> 
> SyntaxError: expected expression, got ';'
> /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1
> 
> Line 269:
> 
> var columns_settings = ;

This is because bug 13618 has been reverted.
@RM Please revert this last patch.
Comment 13 Kyle M Hall 2016-02-29 16:36:25 UTC
(In reply to Jonathan Druart from comment #12)
> (In reply to Owen Leonard from comment #11)
> > (In reply to Kyle M Hall from comment #9)
> > 
> > > Bug 15471 [QA Followup] - Fix error causing visibility button to not display
> > 
> > In my system this follow-up causes an error rather than fixing one.
> > 
> > SyntaxError: expected expression, got ';'
> > /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1
> > 
> > Line 269:
> > 
> > var columns_settings = ;
> 
> This is because bug 13618 has been reverted.
> @RM Please revert this last patch.

Done!
Comment 14 Brendan Gallagher 2016-03-02 22:45:18 UTC
Didn't apply cleanly - I know because of the moving target that master is.  Please rebase.  Once it's done - leave me an @later in #koha and I'll jump right on it.  Thank you so much for the time and bother of rebasing.

Brendan
Comment 16 Jonathan Druart 2016-04-11 06:48:47 UTC
(In reply to Benjamin Rokseth from comment #15)
> Eh, this is already committed to master, no?

Yep!