Add column visibility menu and a text filter on top of each column for the holds queue table
Created attachment 46259 [details] [review] Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns
QA tools say: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt FAIL forbidden patterns forbidden pattern: console.log (line 25)
Oh, sorry, I was not aware of the dependency: Bug 15285. Patch seems to work, though, behalve of the QA tools complaining (see comment #2)
Created attachment 46307 [details] [review] Bug 15471: Add column settings and filters to Holds queue table Same patch with console.log removed
(In reply to Marc Véron from comment #2) > QA tools say: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt > FAIL forbidden patterns > forbidden pattern: console.log (line 25) Sorry about that, this is fixed now
Filtering works OK and I can manage the columns in administration, but I do not see a 'Show / hide columns' on the page itself (like e.g. with the currency table). Should the patch be tested on top of 15285?
Created attachment 46310 [details] [review] Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 47692 [details] [review] Bug 15471: Add column settings and filters to Holds queue table Add column visibility menu using DataTables Buttons Add a text filter on top of each column Also extend page width so that the large table is better centered Depends on bug 15285 Test plan 1. Go to Holds queue page (circ/view_holdsqueue.pl) 2. Check that table sorting and filtering work well and that you can hide each column 3. Go to Admin > Configure columns and change the settings for this table (Circulation > view_holdsqueue > holds-table). Verify that the settings work by going again to the Holds queue page 4. Check that filters continue to work after hiding some columns Tested on top of 15285, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 47693 [details] [review] Bug 15471 [QA Followup] - Fix error causing visibility button to not display Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the may 2016 release. thanks
(In reply to Kyle M Hall from comment #9) > Bug 15471 [QA Followup] - Fix error causing visibility button to not display In my system this follow-up causes an error rather than fixing one. SyntaxError: expected expression, got ';' /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1 Line 269: var columns_settings = ;
(In reply to Owen Leonard from comment #11) > (In reply to Kyle M Hall from comment #9) > > > Bug 15471 [QA Followup] - Fix error causing visibility button to not display > > In my system this follow-up causes an error rather than fixing one. > > SyntaxError: expected expression, got ';' > /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1 > > Line 269: > > var columns_settings = ; This is because bug 13618 has been reverted. @RM Please revert this last patch.
(In reply to Jonathan Druart from comment #12) > (In reply to Owen Leonard from comment #11) > > (In reply to Kyle M Hall from comment #9) > > > > > Bug 15471 [QA Followup] - Fix error causing visibility button to not display > > > > In my system this follow-up causes an error rather than fixing one. > > > > SyntaxError: expected expression, got ';' > > /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1 > > > > Line 269: > > > > var columns_settings = ; > > This is because bug 13618 has been reverted. > @RM Please revert this last patch. Done!
Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan
Eh, this is already committed to master, no? https://github.com/Koha-Community/Koha/commit/fdc06dec2a6e827a5c04c048a0478a2f80d2cd76 https://github.com/Koha-Community/Koha/commit/8e997fbafcc635b275c6ca1211e47a4cd38c8140 https://github.com/Koha-Community/Koha/commit/5f5a7ffaf81a0eaa9240f0790f91b04503484552
(In reply to Benjamin Rokseth from comment #15) > Eh, this is already committed to master, no? Yep!