Bug 15477 - Error handling on editing item type translations
Summary: Error handling on editing item type translations
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 14100 15487
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-06 11:16 UTC by Jonathan Druart
Modified: 2017-06-14 22:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15477: (follow-up) Bug 14100: Better errors handling (2.81 KB, patch)
2016-01-06 11:20 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 15477: (follow-up) Bug 14100: Better errors handling (2.76 KB, patch)
2016-01-06 16:24 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 15477: (follow-up) Bug 14100: Better errors handling (2.90 KB, patch)
2016-01-06 16:34 UTC, Marc Véron 		Details | Diff | Splinter Review
Bug 15477: (follow-up) Bug 14100: Better errors handling (2.82 KB, patch)
2016-01-07 08:34 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 15477: (follow-up) Bug 14100: Better errors handling (2.89 KB, patch)
2016-01-07 13:03 UTC, Marc Véron 		Details | Diff | Splinter Review
[PASSED QA] Bug 15477: (follow-up) Bug 14100: Better errors handling (2.95 KB, patch)
2016-01-07 22:12 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-06 11:16:37 UTC 
The user always get "An error occurred when updating this translation" although it has been updated in DB.
Comment 1 Jonathan Druart 2016-01-06 11:20:55 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-06 14:59:46 UTC 
Hi Jonathan,

I found an encoding issue, maybe it ccould fixed together with this bug:

- Enter Bücher as translation
- Result: String turns to Bücher

- Enter Bande dessinée
- Result: Bande dessinée
Comment 3 Jonathan Druart 2016-01-06 15:52:48 UTC 
(In reply to Marc Véron from comment #2)
> Hi Jonathan,
> 
> I found an encoding issue, maybe it ccould fixed together with this bug:
> 
> - Enter Bücher as translation
> - Result: String turns to Bücher
> 
> - Enter Bande dessinée
> - Result: Bande dessinée

I would prefer on another bug report.
Comment 4 Marc Véron 2016-01-06 16:08:19 UTC 
(In reply to Jonathan Druart from comment #3)
> (In reply to Marc Véron from comment #2)
> > Hi Jonathan,
> > 
> > I found an encoding issue, maybe it ccould fixed together with this bug:
> > 
> > - Enter Bücher as translation
> > - Result: String turns to Bücher
> > 
> > - Enter Bande dessinée
> > - Result: Bande dessinée
> 
> I would prefer on another bug report.

See Bug 15487
Comment 5 Marc Véron 2016-01-06 16:11:55 UTC 
Pach works as expected, QA tools say:
 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt
   FAIL	  forbidden patterns
		forbidden pattern: console.log (line 56)
Comment 6 Jonathan Druart 2016-01-06 16:24:06 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2016-01-06 16:34:24 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2016-01-07 08:34:26 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2016-01-07 08:34:50 UTC 
Rebased on top of bug 15487
Comment 10 Marc Véron 2016-01-07 13:03:57 UTC Comment hidden (obsolete)
Comment 11 Katrin Fischer 2016-01-07 22:12:23 UTC 
Created attachment 46408 [details] [review]
[PASSED QA] Bug 15477: (follow-up) Bug 14100: Better errors handling

On bug 14100, the patch "Better errors handling" introduced an ...
error.
The user always get "An error occurred when updating this translation"
although it has been updated in DB.

Test plan:
Edit translations for an item type: you should not get an error when
everything went fine.

Tested on top of 15487, error message does no longer appear.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Brendan Gallagher 2016-01-12 16:18:08 UTC 
pushed to master - thanks
Comment 13 Julian Maurice 2016-01-15 08:20:58 UTC 
Patch pushed to 3.22.x, will be in 3.22.2