Bug 15478 - Checksum mismatch when regenerating schema
Summary: Checksum mismatch when regenerating schema
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low blocker (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 9303 13624
Blocks: 15517
  Show dependency treegraph
 
Reported: 2016-01-06 12:03 UTC by Kyle M Hall
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15478 - Checksum mismatch when regenerating schema (2.56 KB, patch)
2016-01-06 12:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15478 - Update the remaining schema files that do not match the db schema (7.55 KB, patch)
2016-01-06 12:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15478 - Update the remaining schema files that do not match the db schema (6.63 KB, patch)
2016-01-06 12:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15478 - Checksum mismatch when regenerating schema (2.63 KB, patch)
2016-01-07 10:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15478 - Update the remaining schema files that do not match the db schema (6.70 KB, patch)
2016-01-07 10:42 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2016-01-06 12:03:57 UTC
When regenerating the db schema on master, the script will error out with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm
Comment 1 Kyle M Hall 2016-01-06 12:05:52 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2016-01-06 12:06:30 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2016-01-06 12:20:34 UTC Comment hidden (obsolete)
Comment 4 Julian Maurice 2016-01-06 12:59:20 UTC
Why are these patches already in master ? (status is Needs Signoff)
BTW in master there is still the first version of the 2nd patch, so when I receive a new serial I have a fatal error:

DBIx::Class::ResultSet::new(): No such column serialseq_z on Koha::Schema::Result::Serial at /home/koha/src/Koha/Object.pm line 59
Comment 5 Kyle M Hall 2016-01-06 14:56:37 UTC
(In reply to Julian Maurice from comment #4)
> Why are these patches already in master ? (status is Needs Signoff)
> BTW in master there is still the first version of the 2nd patch, so when I
> receive a new serial I have a fatal error:
> 
> DBIx::Class::ResultSet::new(): No such column serialseq_z on
> Koha::Schema::Result::Serial at /home/koha/src/Koha/Object.pm line 59

Patches were pushed inadvertently, I've revert them in master.
Comment 6 Jonathan Druart 2016-01-07 10:42:48 UTC
Created attachment 46386 [details] [review]
Bug 15478 - Checksum mismatch when regenerating schema

When regenerating the db schema on master, the script will error out
with a checksum mismatch on Borrower.pm, and also DeletedBorrower.pm

Test Plan:
1) Check out master
2) Run ./misc/devel/update_dbix_class_files.pl
3) Note the error
4) Apply this patch
5) Re-reun ./misc/devel/update_dbix_class_files.pl
6) Note there is no error

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2016-01-07 10:42:54 UTC
Created attachment 46387 [details] [review]
Bug 15478 - Update the remaining schema files that do not match the db schema

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Kyle M Hall 2016-01-07 15:05:16 UTC
Considering the triviality of the issue, I think we can jump this to Passed QA. Please knock it back down if you disagree.
Comment 9 Brendan Gallagher 2016-01-07 18:49:45 UTC
Pushed to master
Comment 10 Julian Maurice 2016-01-12 13:03:26 UTC
Does not concern stable versions, changing status to RESOLVED