Bug 15501 - Planned Irregularities are deleted when modifying subscription
Summary: Planned Irregularities are deleted when modifying subscription
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 15657
  Show dependency treegraph
 
Reported: 2016-01-06 16:41 UTC by Koha Team University Lyon 3
Modified: 2019-06-27 09:24 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Add warning when irregularities are set in a subscription pattern (1.42 KB, patch)
2016-01-06 17:06 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 15501 - Planned Irregularities are deleted when modifying subscription (1.57 KB, patch)
2016-01-07 09:52 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 15501 - Planned Irregularities are deleted when modifying subscription (1.65 KB, patch)
2016-01-07 23:15 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 15501 - Planned Irregularities are deleted when modifying subscription (1.70 KB, patch)
2016-01-08 12:36 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2016-01-06 16:41:18 UTC
In an existing subscription where non published issues have been planned through the checkboxes of the prediction patern test, if you modify later a parameter (adding a note for example) without launching the prediction test (you think it's unuseful because you didn't modify the planning itself), there's is no alert,theese data are deleted.


Olivier Crouzet
Comment 1 Koha Team University Lyon 3 2016-01-06 17:06:54 UTC Comment hidden (obsolete)
Comment 2 Koha Team University Lyon 3 2016-01-07 09:52:44 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-07 13:53:46 UTC
Is it still ready to be signed off?
Comment 4 Liz Rea 2016-01-07 23:15:51 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2016-01-08 12:36:27 UTC
Created attachment 46422 [details] [review]
Bug 15501 - Planned Irregularities are deleted when modifying subscription

Add a warning to avoid saving a subscription whitout testing prediction pattern
when there are planned no published issues

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Ran through test plan, looks all good.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Brendan Gallagher 2016-01-12 15:39:40 UTC
Pushed to master - Thanks
Comment 7 Julian Maurice 2016-01-15 08:08:34 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 8 Frédéric Demians 2016-01-25 15:28:25 UTC
Isn't this line problematic?

[% IF ( irregularity ) %]patternneedtobetested=1[% END %]

Shouldn't it be (with ;):

[% IF ( irregularity ) %]patternneedtobetested=1;[% END %]
Comment 9 Jonathan Druart 2016-01-25 16:09:43 UTC
(In reply to Frédéric Demians from comment #8)
> Isn't this line problematic?
> 
> [% IF ( irregularity ) %]patternneedtobetested=1[% END %]
> 
> Shouldn't it be (with ;):
> 
> [% IF ( irregularity ) %]patternneedtobetested=1;[% END %]

I have just tested: no JS error with irregularities.
But it's obviously an error, must be fixed.
Comment 10 Koha Team University Lyon 3 2016-01-25 16:20:03 UTC
Arghhh! you are right, I will post a follow-up

Olivier Crouzet