Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered
Summary: Minor regression caused by Bug 7369 - warn on deleting item not triggered
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 00:27 UTC by Nick Clemens (kidclamp)
Modified: 2017-06-14 22:11 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered (1.79 KB, patch)
2016-01-07 00:30 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered (1.96 KB, patch)
2016-01-08 14:56 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered (2.01 KB, patch)
2016-01-08 18:18 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2016-01-07 00:27:17 UTC
A typo in the code prevents the confirm deletion box form firing when deleting an item using the action menu

To recreate:
Select Action->Delete on the edit item screen.  No warning box and a js error
Delete using a link in another field - get a warning box and no error
Comment 1 Nick Clemens (kidclamp) 2016-01-07 00:30:07 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-01-07 12:18:51 UTC
This looks ready to be signed off.
Comment 3 Marc Véron 2016-01-08 14:56:20 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2016-01-08 18:18:44 UTC
Created attachment 46451 [details] [review]
Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered

To test:
1 - Delete an item using the Action menu
2 - There is a js error and no warning box
3 - Apply patch
4 - Delete an item using the action menu
5 - You should get a confirmation box as expected

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Brendan Gallagher 2016-01-12 16:06:02 UTC
pushed to master thanks
Comment 6 Julian Maurice 2016-01-15 08:23:06 UTC
Patch pushed to 3.22.x, will be in 3.22.2