A typo in the code prevents the confirm deletion box form firing when deleting an item using the action menu To recreate: Select Action->Delete on the edit item screen. No warning box and a js error Delete using a link in another field - get a warning box and no error
Created attachment 46378 [details] [review] Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered To test: 1 - Delete an item using the Action menu 2 - There is a js error and no warning box 3 - Apply patch 4 - Delete an item using the action menu 5 - You should get a confirmation box as expected
This looks ready to be signed off.
Created attachment 46437 [details] [review] Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered To test: 1 - Delete an item using the Action menu 2 - There is a js error and no warning box 3 - Apply patch 4 - Delete an item using the action menu 5 - You should get a confirmation box as expected Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 46451 [details] [review] Bug 15512 - Minor regression caused by Bug 7369 - warn on deleting item not triggered To test: 1 - Delete an item using the Action menu 2 - There is a js error and no warning box 3 - Apply patch 4 - Delete an item using the action menu 5 - You should get a confirmation box as expected Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
pushed to master thanks
Patch pushed to 3.22.x, will be in 3.22.2