Bug 15514 - New professional cataloguing editor does not handle repeatable fields correctly
Summary: New professional cataloguing editor does not handle repeatable fields correctly
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jesse Weaver
QA Contact: Testopia
URL:
Keywords:
Depends on: 11559
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-07 11:01 UTC by Jonathan Druart
Modified: 2017-06-14 22:08 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
bib-112.utf8 (1.39 KB, text/plain)
2016-01-21 08:40 UTC, Jonathan Druart 		Details
Bug 15514: Fix error with certain repeatable fields in Rancor (1.33 KB, patch)
2016-01-27 23:42 UTC, Jesse Weaver 		Details | Diff | Splinter Review
Bug 15514: Fix error with certain repeatable fields in Rancor (1.41 KB, patch)
2016-01-28 10:38 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 15514: Fix error with certain repeatable fields in Rancor (1.46 KB, patch)
2016-02-12 14:59 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-07 11:01:08 UTC 
I get a JS error on saving a record (not modified, just edited an existing one):

TypeError: nonRepeatableSubfields[field.tagnumber(...)] is undefined
...d[0] ] != null && nonRepeatableSubfields[ field.tagnumber() ][ subfield[0] ] )
koha-backend.js (line 229, col 89)

In koha-backend.js
227                     if ( seenSubfields[ subfield[0] ] != null && nonRepeatableSubfields[ field.tagnumber() ][ subfield[0] ] ) {
field.tagnumber() returns 210
The field 210 is not marked as repeatable in my default framework
Comment 1 Jesse Weaver 2016-01-21 00:25:05 UTC 
Could I ask you to attach the record in question? I remember this error popping up during QA on bug 11559, and I'd like to stamp it out for good.
Comment 2 Jonathan Druart 2016-01-21 08:40:50 UTC 
Created attachment 47085 [details]
bib-112.utf8
Comment 3 Jesse Weaver 2016-01-27 23:42:21 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-28 10:38:38 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-01-28 10:39:57 UTC 
Much better.
I now get the "Missing mandatory subfield|tag" error, which is expected.
Comment 6 Kyle M Hall (khall) 2016-02-12 14:59:44 UTC 
Created attachment 47986 [details] [review]
Bug 15514: Fix error with certain repeatable fields in Rancor

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Brendan Gallagher 2016-02-23 23:19:34 UTC 
Pushed to Master - Should be in the May 2016 Release.  Thanks
Comment 8 Julian Maurice 2016-02-26 13:22:54 UTC 
Patch pushed to 3.22.x, will be in 3.22.4