Bug 15519 - Warns when creating a basket
Summary: Warns when creating a basket
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 21:39 UTC by Aleisha Amohia
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15519: Warns when creating a basket (1.50 KB, patch)
2016-01-07 21:44 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 15519: Warns when creating a basket (1.67 KB, patch)
2016-01-08 14:03 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15519: Warns when creating a basket (1.73 KB, patch)
2016-01-11 15:45 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-01-07 21:39:05 UTC
To reproduce:
1) Go to acquisitions
2) Go to a vendor
3) Create a new basket and click save
4) See warn in intranet error log: basket.pl: Argument "" isn't numeric in numeric le (<=) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 207.
Comment 1 Aleisha Amohia 2016-01-07 21:44:06 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-01-08 14:03:42 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-11 15:45:46 UTC
Created attachment 46488 [details] [review]
Bug 15519: Warns when creating a basket

To test:
1) Reproduce warn following steps above
2) Apply patch
3) Create a new basket and click Save. Do not add any items
4) Notice warn is gone
5) Click 'Delete this basket' and confirm that the validation message reads: "Are you sure you want to delete this basket?" Click cancel.
6) Add an order to the basket, then click 'Delete this basket'. Confirm the validation message gives more information and more delete options.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>