The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before...
Created attachment 46475 [details] [review] Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere.
*** Bug 14481 has been marked as a duplicate of this bug. ***
This patch changes koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-us.inc Is there also a need to change koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-de.inc ? (See syspref AddressFormat)
Created attachment 46477 [details] [review] Bug 15542: Change for the German style address format
(In reply to Marc Véron from comment #3) > This patch changes > koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-us.inc > > Is there also a need to change > koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-de.inc > ? (See syspref AddressFormat) Yes of course, done in the second patch.
Sorry, with the syspref 'AddressFormat' set to German, I get: Template process failed: file error - parse error - member-display-address-style-de.inc line 7: unexpected token (roadtype_desc) [% if roadtype_desc %] at /usr/share/kohaclone/C4/Templates.pm line 121. Seems to be due to a missing blank: [%if roadtype_desc %] Makes it fail QA tools as well. BTW: In both the us and the de includes, the if statements are sometimes in capital letters ( [% IF )and sometimes not ( [% if ). Should / could that be streamlined?
Created attachment 46487 [details] [review] Bug 15542: Change for the German style address format
The missing space already existed, but there were parenthesis.
On tab "Files" I get Software error: Global symbol "$address" requires explicit package name at /usr/share/kohaclone/members/files.pl line 126. Global symbol "$roadtype" requires explicit package name at /usr/share/kohaclone/members/files.pl line 127. Execution of /usr/share/kohaclone/members/files.pl aborted due to compilation errors.
Created attachment 46490 [details] [review] Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere.
Created attachment 46491 [details] [review] Bug 15542: Change for the German style address format
Sorry about that Marc, this tab was not displayed on the install I have tested.
Created attachment 46492 [details] [review] Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere.
Created attachment 46493 [details] [review] Bug 15542: Change for the German style address format
Created attachment 46494 [details] [review] Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. Followed test plan, works as expected. (Tested both patches together.) Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 46495 [details] [review] Bug 15542: Change for the German style address format Signed-off-by: Marc Véron <veron@veron.ch>
Thank you for this patch!!
Created attachment 46717 [details] [review] Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. Followed test plan, works as expected. (Tested both patches together.) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46718 [details] [review] Bug 15542: Change for the German style address format Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46719 [details] [review] Bug 15542 [QA Followup] - Fix code error Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46720 [details] [review] Bug 15542 [QA Followup] - Tidy member-password.pl No other patches in process modify member-password.pl, now would be a great time to tidy it! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 46721 [details] [review] Bug 15542 [QA Followup] - Tidy member-password.pl No other patches in process modify member-password.pl, now would be a great time to tidy it! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patches pushed to 3.22.x, will be in 3.22.2
(In reply to Kyle M Hall from comment #22) > No other patches in process modify member-password.pl, now would be > a great time to tidy it! Yes, bug 15407 was there.