Bug 15554 - Organize entries in ccl.properties
Summary: Organize entries in ccl.properties
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2016-01-11 23:07 UTC by David Cook
Modified: 2019-10-14 19:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2016-01-11 23:07:29 UTC
At the moment, ccl.properties is fairly disorganized. Once upon a time, it may have been organized numerically or alphabetically, but that seems to have gone out the window a bit. 

It would be nicer if it followed a similar scheme to https://www.loc.gov/z3950/agency/defns/bib1.html

That is, qualifiers and aliases would be grouped into Bib-1 attribute categories: 

1. Use Attributes
2. Relation Attributes
3. Position Attributes
4. Structure Attributes
5. Truncation Attributes
6. Completeness Attributes
--
Indexdata Extensions:
7. Sort
9. Ranking

In other words, all entries that roughly follow the pattern "Qualifier 1=[A-Za-z0-9]+" would be grouped in "1. Use Attributes". 

Examples: 
Abstract 1=62
ab Abstract

Any 1=1016
kw Any

Likewise, entries following the pattern "Qualifier 2=[A-Za-z0-9]+" would be grouped in "2. Relation Attributes".

Examples:

lt 2=1
le 2=2
eq 2=3
ge 2=4
gt 2=5
ne 2=6

---

That said... maybe it makes sense to group together qualifiers that are functionally similar. Like everything found around the comment "# Koha Local-Use Authority Indexes" or "# Subdivisions".

I'm not 100% sure how we should order qualifier (and alias) entries within their respective Bib-1 attribute categories. We could do it alphabetically or numerically (although some entries use index string names rather than numerical values. Example: Geographic-subdivision 1=Geographic-subdivision).
Comment 1 David Cook 2016-01-11 23:08:32 UTC
In any case, it might also be good to have a test in "xt" which checks to make sure that no entries have been added or lost during the re-organization process...
Comment 2 Grace 2018-01-16 22:57:24 UTC
Hi David,
I have checked ccl.properties and it seems like this bug has been patched and the code is organised.
Thanks :)
Comment 3 Owen Leonard 2018-10-02 14:40:48 UTC
Switching this to "New" from "needs signoff" since there are no patches. Can anyone confirm whether this bug is still valid?
Comment 4 David Cook 2018-10-04 01:10:05 UTC
Looking at ccl.properties, it looks like it's still disorganized, but at this point in time... I don't know that it really matters.

I think Zebra's days are numbered, so there's probably not much point investing time in this bug report.