Bug 15569 - Automatic renewal should not be displayed if the patron cannot checkout
Summary: Automatic renewal should not be displayed if the patron cannot checkout
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 10860 11577
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-13 16:36 UTC by Jonathan Druart
Modified: 2021-03-10 18:02 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout (2.14 KB, patch)
2016-01-13 16:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout (2.14 KB, patch)
2016-01-13 16:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout (2.30 KB, patch)
2016-01-14 16:22 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout (2.35 KB, patch)
2016-01-15 15:39 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15563: add option to cleanup_database to delete old label and card batches (2.00 KB, text/plain)
2021-03-10 18:01 UTC, Andrew Fuerste-Henry
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-13 16:36:41 UTC
If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen.
Comment 1 Jonathan Druart 2016-01-13 16:38:35 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-01-13 16:47:39 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2016-01-14 16:22:23 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-01-14 16:38:05 UTC
Question: When renewals are not possible, should the form field "Renewal due date: ..." be removed as well?
Comment 5 Jonathan Druart 2016-01-15 10:08:09 UTC
(In reply to Marc Véron from comment #4)
> Question: When renewals are not possible, should the form field "Renewal due
> date: ..." be removed as well?

At the bottom of the table, that's it (not auto renewal related)?
Comment 6 Marc Véron 2016-01-15 10:39:58 UTC
(In reply to Jonathan Druart from comment #5)
> (In reply to Marc Véron from comment #4)
> > Question: When renewals are not possible, should the form field "Renewal due
> > date: ..." be removed as well?
> 
> At the bottom of the table, that's it (not auto renewal related)?

Yes, at the bottom of the table. It was just a question - I think this should have it's own bug (if we decide to remove it).
Comment 7 Kyle M Hall 2016-01-15 15:39:00 UTC
Created attachment 46701 [details] [review]
Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout

If the patron cannot checkout (debarred) and on-site checkout is
enabled, the "Automatic renewal" checkbox should not be displayed on the
circulation screen.

Test plan:
Enable OnSiteCheckouts and OnSiteCheckoutsForce
Debar a patron and go on the circulation page.
Without this patch, the automatic renewal checkbox is displayed.
With this patch applied, it's not.

Patch works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Brendan Gallagher 2016-01-23 19:21:27 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 9 Julian Maurice 2016-01-25 12:08:58 UTC
Patch pushed to 3.22.x, will be in 3.22.2
Comment 10 Frédéric Demians 2016-01-25 16:28:34 UTC
This patch has been pushed to 3.20.x, will be in 3.20.8.
Comment 11 Andrew Fuerste-Henry 2021-03-10 18:01:52 UTC
Created attachment 118077 [details]
Bug 15563: add option to cleanup_database to delete old label and card batches

To test:
For item label batches:
1- Create 3 item label batches of at least 2 items each
2- Perform the following updates via the database
3- In Batch 1, set all items' timestamps to 10+ days prior to today
4- In Batch 2, set 1 item's timestamp to 10+ days prior to today
5- In Batch 3, do not update any timestamps
6- Run cron with --labels 9
7- Confirm batch 1 is deleted, batches 2 and 3 are not

Repeat with card creator batches
8- Create 3 card creator batches of at least 2 items each
9- Perform the following updates via the database
10- In Batch 1, set all cards' timestamps to 10+ days prior to today
11- In Batch 2, set 1 card's timestamp to 10+ days prior to today
12- In Batch 3, do not update any timestamps
13- Run cron with --cards 9
14- Confirm batch 1 is deleted, batches 2 and 3 are not
Comment 12 Andrew Fuerste-Henry 2021-03-10 18:02:54 UTC
Comment on attachment 118077 [details]
Bug 15563: add option to cleanup_database to delete old label and card batches

mistyped a bug number, sorry!