Deactivating the reserveforothers permission (or place_holds) effectively keeps staff from placing holds for patrons, but it should also remove the button from the patron screens (circulation.pl, moremember.pl, pay.pl, routing-lists.pl, notices.pl, statistics.pl, etc.). Christopher
Adding a check for the permission in the template should work here.
Created attachment 46828 [details] [review] Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there
Created attachment 46995 [details] [review] [SIGNED-OFF] Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Hi Briana, There are 2 subpermissions in the reserveforothers permission: - modify_holds_priority: Modify holds priority - place_holds: Place holds for patrons It would make more sense to test CAN_user_reserveforothers_place_holds instead. Katrin, could you confirm? It seems that we currently test CAN_user_reserveforothers in other places, but it does not look good.
Created attachment 47054 [details] [review] Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Briana <brianagreally@gmail.com> Here is the same patch but with 'CAN_user_reserveforothers_place_holds'
I think place_holds is a good pick!
Created attachment 47210 [details] [review] Bug 15571 reserveforothers permission does not remove Search to hold button from patron account To Test: 1. Create a user without 'reserveforothers' permission 2. Go onto user details 3. 'Search to hold' button should not be there 4. Create a user with 'reserveforothers' permission 5. Repeat steps 6. 'Search to Hold' button should be there Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Briana <brianagreally@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 47211 [details] [review] Bug 15571 [QA Followup] - Remove tabs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Kyle, did you read comments 4 and 6?
I think they might have accidentally uploaded the wrong patch or forgot to include the change mentioned in comment#5. Can we fix this in a little follow-up please?
This subpermission is never checked actually. So either we only test for CAN_user_reserveforothers everywhere or we change all the appropriate occurrences with CAN_user_reserveforothers_place_holds
Hm, so maybe push this patch as is and then to a general clean-up separately?
yep, agreed.
Pushed to Master - Should be in the May 2016 release. Thanks!
Patches pushed to 3.22.x, will be in 3.22.4
This patch has been pushed to 3.20.x, will be in 3.20.9.