Bug 15578 - Authority tests skip and hide a bug
Summary: Authority tests skip and hide a bug
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 14639 15380
Blocks: 15358
  Show dependency treegraph
 
Reported: 2016-01-14 12:26 UTC by Jonathan Druart
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15578: Insert authority records before processing tests (3.16 KB, patch)
2016-01-14 12:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15578: Make sure all params will be taken into account when instantiating (1.41 KB, patch)
2016-01-14 12:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15578: Insert authority records before processing tests (3.22 KB, patch)
2016-01-15 00:54 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15578: Make sure all params will be taken into account when instantiating (1.50 KB, patch)
2016-01-15 00:55 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15578: Insert authority records before processing tests (3.27 KB, patch)
2016-01-15 16:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 15578: Make sure all params will be taken into account when instantiating (1.54 KB, patch)
2016-01-15 16:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
[3.22.x] Bug 15578: Insert authority records before processing tests (3.13 KB, patch)
2016-02-04 11:02 UTC, Julian Maurice
Details | Diff | Splinter Review
[3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating (1.42 KB, patch)
2016-02-04 11:02 UTC, Julian Maurice
Details | Diff | Splinter Review
[3.22.x] Bug 15578: Insert authority records before processing tests (3.19 KB, patch)
2016-02-17 10:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
[3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating (1.48 KB, patch)
2016-02-17 10:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-14 12:26:43 UTC
The tests in t/db_dependent/Koha_Authority.t expects at least 1 authority record in the DB to run them, otherwise they are skipped.
On our integration server, the DB does not contain any records, and the tests are skipped.
Unfortunately these tests were testing the authid method of Koha::MetadataRecord::Authority.
Comment 1 Jonathan Druart 2016-01-14 12:29:41 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-01-14 12:29:43 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-01-15 00:54:51 UTC Comment hidden (obsolete)
Comment 4 Héctor Eduardo Castro Avalos 2016-01-15 00:55:20 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2016-01-15 16:41:32 UTC
Created attachment 46711 [details] [review]
Bug 15578: Insert authority records before processing tests

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2016-01-15 16:41:41 UTC
Created attachment 46712 [details] [review]
Bug 15578: Make sure all params will be taken into account when instantiating

The tests in t/db_dependent/Koha_Authority.t expects at least 1
authority record in the DB to run them, otherwise they are skipped.
On our integration server, the DB does not contain any records, and the
tests are skipped.
Unfortunately these tests were testing the authid method of
Koha::MetadataRecord::Authority.

Test plan:
Apply the first patch, launch tests
=> Fail
Apply the second patch, launch tests
=> \o/

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Test pass successfuly

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Brendan Gallagher 2016-01-23 18:41:19 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 8 Julian Maurice 2016-02-01 16:45:15 UTC
This bug does not concern stable versions, changing status to RESOLVED
Comment 9 Julian Maurice 2016-02-04 10:55:07 UTC
Actually those patches are needed for bug 15358.
Reopening...
Comment 10 Julian Maurice 2016-02-04 11:02:03 UTC Comment hidden (obsolete)
Comment 11 Julian Maurice 2016-02-04 11:02:08 UTC Comment hidden (obsolete)
Comment 12 Julian Maurice 2016-02-04 11:04:19 UTC
Original patches don't apply well on 3.22.x, so here are the patches for 3.22.
If someone else can test and signoff them, that would be great :)
Comment 13 Katrin Fischer 2016-02-13 22:15:48 UTC
It looks like we need a sign-off on the patches on 15578 in order to get this into 3.22.
Comment 14 Julian Maurice 2016-02-17 09:21:18 UTC
I think I'll push these patches even without a signoff, because it blocks bug 15358 which is a "blocker". Moreover, 15358's patch for 3.22 has been signed off, which mean this bug's patches kind of work too :)
That being said, I would still like those patches to be signed off before I push them ;) (probably tomorrow or the day after)
Comment 15 Jonathan Druart 2016-02-17 10:31:49 UTC
Created attachment 48156 [details] [review]
[3.22.x] Bug 15578: Insert authority records before processing tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 16 Jonathan Druart 2016-02-17 10:32:03 UTC
Created attachment 48157 [details] [review]
[3.22.x] Bug 15578: Make sure all params will be taken into account when instantiating

The tests in t/db_dependent/Koha_Authority.t expects at least 1
authority record in the DB to run them, otherwise they are skipped.
On our integration server, the DB does not contain any records, and the
tests are skipped.
Unfortunately these tests were testing the authid method of
Koha::MetadataRecord::Authority.

Test plan:
Apply the first patch, launch tests
=> Fail
Apply the second patch, launch tests
=> \o/

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 17 Jonathan Druart 2016-02-17 10:32:42 UTC
Let's sign my own patches off...
Comment 18 Julian Maurice 2016-02-17 18:54:18 UTC
Patches pushed to 3.22.x, will be in 3.22.4

Thanks Jonathan