15583 – List of lists in the staff client should have a default sort

Bug 15583 - List of lists in the staff client should have a default sort

Summary: List of lists in the staff client should have a default sort

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Lists (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Chloe Alabaster
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:

Reported:	2016-01-15 13:30 UTC by Owen Leonard
Modified:	2017-06-14 22:11 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15583 - List of lists in the staff client should have a default sort (1.47 KB, patch) 2016-01-20 23:19 UTC, Chloe Alabaster	Details \| Diff \| Splinter Review
[SIGNED-OFF] Bug 15583 - List of lists in the staff client should have a default sort (1.58 KB, patch) 2016-01-21 15:24 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 15583 - List of lists in the staff client should have a default sort (1.60 KB, patch) 2016-01-22 09:24 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2016-01-15 13:30:55 UTC

The list of lists in the staff client seems to default to a sort by shelfnumber. While it may make sense to sort lists by creation date, I think in that case the DataTable should be configured to explicitly sort by creation date rather than have there be no visible sense to the default sort.

Comment 1 Chloe Alabaster 2016-01-20 23:19:56 UTC Comment hidden (obsolete)

Created attachment 47064 [details] [review]
Bug 15583 - List of lists in the staff client should have a default sort

To Test:

1- first make sure you have lists from different dates,
-- if you dont you can go to databases and change the created_on date (by changing the date on the database you can also ensure that the shelfnumber doesn't align with the creation date, replicating the bug being fixed.)
2- after making lists apply patch and refresh page, the lists should be sorted by creation date by default instead of by the "shelfnumber"

Comment 2 Owen Leonard 2016-01-21 15:24:03 UTC Comment hidden (obsolete)

Created attachment 47136 [details] [review]
[SIGNED-OFF] Bug 15583 - List of lists in the staff client should have a default sort

To Test:

1- first make sure you have lists from different dates,
   -- if you dont you can go to databases and change the created_on date
   (by changing the date on the database you can also ensure that the
    shelfnumber doesn't align with the creation date, replicating the
   bug being fixed.)
2- after making lists apply patch and refresh page, the lists should be
   sorted by creation date by default instead of by the "shelfnumber"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Jonathan Druart 2016-01-22 09:24:10 UTC

Created attachment 47163 [details] [review]
Bug 15583 - List of lists in the staff client should have a default sort

To Test:

1- first make sure you have lists from different dates,
   -- if you dont you can go to databases and change the created_on date
   (by changing the date on the database you can also ensure that the
    shelfnumber doesn't align with the creation date, replicating the
   bug being fixed.)
2- after making lists apply patch and refresh page, the lists should be
   sorted by creation date by default instead of by the "shelfnumber"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 4 Brendan Gallagher 2016-01-27 05:34:45 UTC

Pushed to Master - Should be in the May 2016 release. Thanks!