Bug 15595 - Display Google cover image on staff interface search list and detail page
Summary: Display Google cover image on staff interface search list and detail page
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: jwayway
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2016-01-19 04:36 UTC by Iming Chan
Modified: 2023-08-28 20:50 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Decided to make no cover message the same (5.18 KB, patch)
2018-01-18 21:15 UTC, jwayway
Details | Diff | Splinter Review
Bug-15595: Google cover staff search and detail (23.52 KB, patch)
2018-01-18 21:24 UTC, jwayway
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Iming Chan 2016-01-19 04:36:59 UTC
Ability to display book cover images from Google Books on staff client search list and detail page.  

Currently, this is available to OPAC result list and detail page only.
Comment 1 jwayway 2018-01-18 21:15:12 UTC
Created attachment 70719 [details] [review]
Decided to make no cover message the same
Comment 2 jwayway 2018-01-18 21:24:02 UTC
Created attachment 70721 [details] [review]
Bug-15595: Google cover staff search and detail

Test plan:
1. Apply patch
2. In system preferences enable GoogleJacketsIntra
3. Cover images from Google should show in results page and detail page
4. If the record doesn't have a cover, it should display "No cover image
available"
4. Disabling the GoogleJacketIntra will cause the cover images not to
show
5. Without patch there is no GoogleJacketsIntra syspref
Comment 3 Victor Grousset/tuxayo 2018-03-12 15:35:24 UTC
conflict:

~/d/koha ❯❯❯ git bz apply 15595
Bug 15595 - Display Google Jacket image on staff client search list and detail page

70721 - Bug-15595: Google cover staff search and detail

Apply? [(y)es, (n)o, (i)nteractive] y
Application de  Bug-15595: Google cover staff search and detail
.git/rebase-apply/patch:45: trailing whitespace.
  
warning: 1 ligne a ajouté des erreurs d'espace.
Utilisation de l'information de l'index pour reconstruire un arbre de base...
M	installer/data/mysql/sysprefs.sql
M	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
M	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
.git/rebase-apply/patch:45: trailing whitespace.
  
warning: 1 line applied after fixing whitespace errors.
Retour à un patch de la base et fusion à 3 points...
Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
CONFLIT (contenu) : Conflit de fusion dans koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
Fusion automatique de koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
CONFLIT (contenu) : Conflit de fusion dans koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Fusion automatique de installer/data/mysql/sysprefs.sql
error: Échec d'intégration des modifications.
le patch a échoué à 0001 Bug-15595: Google cover staff search and detail
La copie du patch qui a échoué se trouve dans : .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15595-Google-cover-staff-search-and-detail-YnkBAW.patch