Created attachment 46896 [details] Broken appearance of the toolbar In system preferences, when you scroll down a long page the toolbar with the "save" button "sticks" to the top of the browser window so that the button is always accessible. Since the addition of the professional cataloging interface (Bug 11559) the appearance of this toolbar has been broken (improper passing, transparent background).
Created attachment 46897 [details] Correct appearance of the toolbar
Created attachment 46952 [details] This is what I have done so far with the toolbar I changed the color of the tool bar so that it was no longer "transparent" however now from this you cant tell that the "submit" button is a button. Will start working on a way to make this noticeable.
Created attachment 46960 [details] when testing it should look like this: this what the tool bar should look like with this patch
Created attachment 46961 [details] when testing the hover: in addition to the screen shot above; when hovering over it should look like this
Created attachment 46962 [details] [review] Bug 15600 - System preferences broken toolbar looks broken To test: 1-see without patch the toolbar looks transparent and "broken" 2-apply patch, with this the toolbar is solid and has new colours (including the hover) -see screenshots for examples 3-try scrolling on different tabs to the left eg "OPAC" and that the style continues with them
Hi Chloe, the patch works for me. But I think the nondescript look of the button is intended. What you could try: before applying your patch, open a part of the system preferences that needs scrolling to see all parameters. Scroll down a bit so you get the toolbar. The button is not very impressive. Then go into one of the parameter fields and change it. The button changes the layout now and looks more button-like, because there are changes to save. Do you see what I mean?
I think the correct solution is to look at the commit that created the bug and see what changes were the cause: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=edd64d30188fef2b3ecb314ceeb1f613e2217cc2 The problem stems from the fact that Bug 11559 made changes to staff-global.css in a way that didn't take into account the toolbar in system preferences. http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css;h=11781bce7874c5e4c4d482c300666fd020039979;hp=d33580ab1d216f4f3b35b459dc22055587317b67;hb=edd64d30188fef2b3ecb314ceeb1f613e2217cc2;hpb=ac05c178b0317c570aa21bd5d2d5adf34cef38f2 As far as I can tell based on my test the deletions from staff-global.css made by that commit can be reversed while keeping the additions. I'm going to try to ask pianohacker if he knows of a reason not to do that.
Created attachment 48211 [details] [review] Bug 15600 - System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly.
Created attachment 48241 [details] [review] [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken To test: 1-see without patch the toolbar looks transparent and "broken" 2-apply patch, with this the toolbar is solid and has new colours (including the hover) -see screenshots for examples 3-try scrolling on different tabs to the left eg "OPAC" and that the style continues with them Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Created attachment 48242 [details] [review] [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tollbar looks correct
Do we need both patches? With both patches applied, the button does not look disabled if nothing has been changed, it's a bit confusing (and the cursor is the cursor is a pointer). With only the following change, I get what is (I think) is expected: diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css index b35e6be..06c39c2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css +++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css @@ -422,7 +422,7 @@ dd { font-weight : normal; } -.btn-toolbar { +div#toolbar, .btn-toolbar { background-color : #EDF4F6; padding: 5px 5px 5px 5px; border-radius: 5px 5px 0 0;
No we don't need both patches. I think mine is the correct solution.
Comment on attachment 48241 [details] [review] [SIGNED-OFF]Bug 15600: System preferences broken toolbar looks broken (In reply to Owen Leonard from comment #12) > No we don't need both patches. I think mine is the correct solution. It's right, doing obsolete Chloe's patch.
Created attachment 48264 [details] [review] Bug 15600: System preferences broken toolbar looks broken This patch reverts some deletions made to staff-global.css in Bug 11559. The deletions broke the appearance of the floating toolbar in system preferences. To test, apply the patch and clear your browser cache if necessary. - Go to Administration -> System preferences and view a tab with enough content to allow you to scroll and test the appearance of the floating toolbar. Confirm that it looks correct. - Open the advanced cataloging editor and confirm that its toolbar looks correct. - Open the normal cataloging editor and confirm that the floating toolbar looks correct and works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tollbar looks correct Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
cool! Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.4