Bug 15626 - koha-remove does not remove log4perl.conf
Summary: koha-remove does not remove log4perl.conf
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 14167
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-20 10:27 UTC by Jonathan Druart
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 15626: Remove log4perl.conf when using koha-remove (1.32 KB, patch)
2016-01-20 10:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 15626: Remove log4perl.conf when using koha-remove (1.40 KB, patch)
2016-01-20 19:47 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15626: Remove log4perl.conf when using koha-remove (1.45 KB, patch)
2016-01-22 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2016-01-20 10:27:58 UTC

    
Comment 1 Jonathan Druart 2016-01-20 10:32:17 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-20 19:47:32 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2016-01-22 16:07:10 UTC
Created attachment 47194 [details] [review]
Bug 15626: Remove log4perl.conf when using koha-remove

if you create a koha install using koha-create, and remove it with
koha-remove, the /etc/koha/sites/$SITE/ directory won't be removed,
because the /etc/koha/sites/$SITE/log4perl.conf has not been removed by
this script.

Test plan:
Use this koha-remove script to remove a koha install
Without this patch, the /etc/koha/sites/$SITE directory won't be
removed.
With this patch applied, the directory will be correctly removed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Brendan Gallagher 2016-01-27 01:12:54 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks.
Comment 5 Julian Maurice 2016-01-27 14:37:41 UTC
Patch pushed to 3.22.x, will be in 3.22.3