Bug 15643 - Every datepicker on serials expected date column updates top issue
Summary: Every datepicker on serials expected date column updates top issue
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Koha Team University Lyon 3
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-22 09:17 UTC by Koha Team University Lyon 3
Modified: 2019-06-27 09:24 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15643 - Every datepicker on serials expected date column updates top issue (1.30 KB, patch)
2016-01-22 09:20 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 15643 - Every datepicker on serials expected date column updates top issue (3.63 KB, patch)
2016-01-26 12:22 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 15643 - Every datepicker on serials expected date column updates top issue (3.80 KB, patch)
2016-01-28 08:47 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15643 - Every datepicker on serials expected date column updates top issue (4.43 KB, patch)
2016-01-29 11:24 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2016-01-22 09:17:44 UTC
In the serials edition page, on 'Expected on' column, whatever item date you try to change using its datepicker, it modify the top item date and only this one.

Test plan :
1) Search a serial subscription from the Serials Home page
2)Go to serial collection page and make sure it has a mimimal bunch of already received  or missing issues
3)Check some received issues to be sure to get extra issues (not only the extected one) in the serial edition page
4) Click on Edit serials button
5) Try to modify whatever date in 'Expected on' column (excepted first one) using datepicker :
You can see that the top date of the column is updated instead of the choosen one.
6) Apply patch and redo 1 to 5 steps : 
now the right date is updated.
Comment 1 Koha Team University Lyon 3 2016-01-22 09:20:49 UTC Comment hidden (obsolete)
Comment 2 Koha Team University Lyon 3 2016-01-25 09:44:25 UTC
Comment on attachment 47162 [details] [review]
Bug 15643 - Every datepicker on serials expected date column updates top issue

This patch is wrong : the expected date is not any more updated to current date when adding an item
Comment 3 Koha Team University Lyon 3 2016-01-26 12:22:46 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2016-01-28 08:47:02 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2016-01-29 11:24:42 UTC
Created attachment 47456 [details] [review]
Bug 15643 - Every datepicker on serials expected date column updates top issue

delete 'expected' and 'supexpected' ids that don't seem useful anymore.
Same thing for changeDate2 function

Test plan :
1) Search a serial subscription from the Serials Home page
2)Go to serial collection page and make sure it has a mimimal bunch of
already received  or missing issues
3)Check some received issues to be sure to get extra issues (not only
the extected one) in the serial edition page
4) Click on Edit serials button
5) Try to modify whatever date in 'Expected on' column (excepted first
one) using datepicker :
You can see that the top date of the column is updated instead of the
choosen one.
6) Apply patch and redo 1 to 5 steps :
now the right date is updated.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Brendan Gallagher 2016-02-23 15:25:14 UTC
Pushed to Master - Should be in the May 2016 Release. Thanks!
Comment 7 Julian Maurice 2016-02-26 09:56:37 UTC
Patch pushed to 3.22.x, will be in 3.22.4