When modifying a patron the dropdown for cities selection tries to select the existing patron's info in the city dropdown menu but matches only on city For cities with multiple zipcodes, or states with matching city names it can select the wrong info. This does not affect data entry, but can be confusing to staff. To recreate: 1 - Enter two cities via Administration->Patrons and circulation->Cities and towns: Springfield, MA 01101 Springfield, VT 05156 2 - Edit a patron chossing Springfield VT 3 - Load thei record in the editor and note that Springfield MA is the selected value in the dropdown Either we should match on zipcode (unique id?) or default to blank
*** Bug 18744 has been marked as a duplicate of this bug. ***
Created attachment 64082 [details] Example
Created attachment 64111 [details] [review] Bug 15644 - City dropdown default selection when modifying a patron matches only on city This patch modifies the include files which contain the form fields for city, state, zipcode, etc. shown on the patron entry screen. The files are modified so that the city/state/zip <select> preselects a value based on city, state, and zipcode matching the values in the corresponding text fields. To test, confirm that the bug's steps to reproduce are fixed: - Enter two cities via Administration -> Patrons and circulation -> Cities and towns: Springfield, MA 01101 Springfield, VT 05156 - Edit a patron choosing, Springfield VT, and save. - Edit the patron again and confirm that the correct city is pre-selected. - Confirm this result with all three different settings of the "AddressFormat" system preference.
Created attachment 66010 [details] [review] Bug 15644 - City dropdown default selection when modifying a patron matches only on city Works perfectly.
Created attachment 67002 [details] [review] [SIGNED-OFF] Bug 15644 - City dropdown default selection when modifying a patron matches only on city This patch modifies the include files which contain the form fields for city, state, zipcode, etc. shown on the patron entry screen. The files are modified so that the city/state/zip <select> preselects a value based on city, state, and zipcode matching the values in the corresponding text fields. To test, confirm that the bug's steps to reproduce are fixed: - Enter two cities via Administration -> Patrons and circulation -> Cities and towns: Springfield, MA 01101 Springfield, VT 05156 - Edit a patron choosing, Springfield VT, and save. - Edit the patron again and confirm that the correct city is pre-selected. - Confirm this result with all three different settings of the "AddressFormat" system preference. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14. Note: French format doesn't exist in 16.11.x and has been removed from the patch.
Pushed to 16.05.x, for 16.05.19 release