Bug 15652 - Allow current date in datepicker on opac-reserve
Summary: Allow current date in datepicker on opac-reserve
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-25 12:13 UTC by Marcel de Rooy
Modified: 2017-06-14 22:11 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15652: Allow current date in datepicker on opac-reserve (2.33 KB, patch)
2016-01-25 13:00 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15652: Allow current date in datepicker on opac-reserve (2.38 KB, patch)
2016-01-25 15:17 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15652: Allow current date in datepicker on opac-reserve (2.43 KB, patch)
2016-01-27 14:09 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2016-01-25 12:13:38 UTC

    
Comment 1 Marcel de Rooy 2016-01-25 13:00:21 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-25 15:17:45 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-27 10:43:51 UTC
Does it make sense to have 'Hold not needed after' set to today?
Comment 4 Marcel de Rooy 2016-01-27 12:15:50 UTC
(In reply to Jonathan Druart from comment #3)
> Does it make sense to have 'Hold not needed after' set to today?

Only a little little bit. See my commit message btw (" I only want this book today or not" ).
For the most, it keeps the code cleaner, more consistent perhaps?
In the end, it does not harm at all..
Comment 5 Jonathan Druart 2016-01-27 14:09:18 UTC
Created attachment 47347 [details] [review]
Bug 15652: Allow current date in datepicker on opac-reserve

If you enable AllowHoldDateInFuture (and its OPAC variant), you get
an additional "Hold starts on date". In that field and in "Hold not
needed after" it was not possible to enter the current date.

Although it does not really make any difference if you leave the startdate
empty or put the current date in it, we concluded that it still makes
a psychological difference. Some patrons were confused when placing a
hold because the first date to select was tomorrow. Instead of telling
them "Yes, but you can leave it empty", we should just allow the current
date as well.

The expiration date ("not needed after") also started on tomorrow. (This
field can really be empty.) But there is actually no reason not to allow
today here too. If the patron only wants it today, why force tomorrow?

How is this arranged? Well, this is one of the simplest Koha patches ever
written. It only changes the minDate option of both date pickers in one
line from 1 to 0.

Test plan:
[1] Allow future hold dates via systempreferences.
[2] Verify that you can enter today in both fields.
[3] Put today in start and expiration date. Place the hold and verify that
    you can confirm the hold, check out and check in again.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Brendan Gallagher 2016-02-24 02:19:24 UTC
Pushed to Master - Should be in the May 2016 Release. Thanks!
Comment 7 Julian Maurice 2016-02-26 15:19:55 UTC
Patch pushed to 3.22.x, will be in 3.22.4